Hi @joalif,
couple changes needed in the debdiffs, please:
1) the patch "debian/patches/fix_missing_null_termination" has no suffix...
not a major problem but convention is to suffix it with ".diff" or ".patch"
2) The line in your patch:
+ * Fix missing null terminated buffer. Closes: #853497.
should be removed; the text is redundant with the line above it, and the
patch doesn't actually fix Debian bug 853497 (as far as I can tell, at
least). Also, Ubuntu debdiffs shouldn't include Debian-specific Closes:
tags...which leads to:
3) Your changelog entry contains "(Closes: #1573594)", but Ubuntu uses
"(LP: #NNNNNN)" tag formatting. Please change your changelog entry to
include "(LP: #1573594)" instead.
4) All your debdiffs include the same package version: 1.0.18-4.2ubuntu1
This is a tricky point of pkg versioning; since they are currently
identical in multiple releases, it's best to use a release-specific
version number for each of the SRU releases, and only use the "ubuntu1"
suffix for the development (i.e. disco) release.
Specifically to clarify:
release current version new version
Xenial 1.0.18-4.1 1.0.18-4.1ubuntu1
Bionic 1.0.18-4.2 1.0.18-4.2ubuntu0.18.04.1
Cosmic 1.0.18-4.2 1.0.18-4.2ubuntu0.18.10.1
Disco 1.0.18-4.2 1.0.18-4.2ubuntu1
I can make the changes to the debdiffs you already uploaded if you want,
or please upload new debdiffs with the recommended changes.
Thanks!
** Tags removed: sts-sponsor
** Tags added: sts-sponsor-ddstreet
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1573594
Title:
Missing null termination in PROTOCOL_BINARY_CMD_SASL_LIST_MECHS
response handling
To manage notifications about this bug go to:
https://bugs.launchpad.net/libmemcached/+bug/1573594/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
