** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] + Note: No ADT test has been reported since 21.5 ... between 21.5 and now + (21.11) everything released has been about security fixes : + + systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU + systemd (229-4ubuntu21.10) xenial-security; urgency=medium + systemd (229-4ubuntu21.9) xenial-security; urgency=medium + systemd (229-4ubuntu21.8) xenial-security; urgency=medium + systemd (229-4ubuntu21.6) xenial-security; urgency=medium + systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU + + * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for systemd (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/s/systemd/20181213_162040_4f06f@/log.gz Error: FileNotFoundError: [Errno 2] No such file or directory: '/boot/grub/grub.cfg' Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. - * Regression in autopkgtest for umockdev (i386): test log - * * * * [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No ADT test has been reported since 21.5 ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU + Unless security team has some ADT report elsewhere, the only data + available I have is if the ADT tests were "failling" or "passing" on + 21.5. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for systemd (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/s/systemd/20181213_162040_4f06f@/log.gz Error: FileNotFoundError: [Errno 2] No such file or directory: '/boot/grub/grub.cfg' Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. * * * [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 ** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] - Note: No ADT test has been reported since 21.5 ... between 21.5 and now - (21.11) everything released has been about security fixes : + Note: No autopkgtests has been reported since systemd (21.5) ... between + 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU - Unless security team has some ADT report elsewhere, the only data - available I have is if the ADT tests were "failling" or "passing" on - 21.5. + Unless security team has some autopkgtests reports elsewhere, the only + data available I have (to compare) is if the autopkgtests were + "failling" or "passing" when 21.5 has been pushed. Since then quite a + few release has been uploaded with no autopkgtests report. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for systemd (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/s/systemd/20181213_162040_4f06f@/log.gz Error: FileNotFoundError: [Errno 2] No such file or directory: '/boot/grub/grub.cfg' Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. * * * [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1795764/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
