(In reply to Roy Richardson from comment #76) > I'm suspicious of the following code fragment in thunar_folder_monitor which > I have now bypassed on "file monitor move" events with the above patch. > > /* tell others about the new file */ > list.data = file; list.next = list.prev = NULL; > g_signal_emit (G_OBJECT (folder), folder_signals[FILES_ADDED], 0, > &list); > > It is passing the address of a local GList variable to the "files added" > signal handler. This needs further investigation as potential stack > corruption.
The passing of the local GList variable by address to the "files added" signal handler does not seem to be causing any problems as far as I can see. The problems seem to be caused when files are added to the list model multiple times by the file monitor after a move / rename operation. This seems to have somehow resulted in NULL collate keys which are causing the crash in strcmp(). The patch of thunar_folder_monitor to stop the "files added" on "move event" behavior is still working for me. I have not been able to crash Thunar with a rename or a move file since I have applied the patch. I am also not seeing the duplicate file anomoly that I see when just using the patch on thunar_file_compare_by_name(). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage notifications about this bug go to: https://bugs.launchpad.net/thunar/+bug/1512120/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
