** Description changed: + [Impact] + + * Due to a bug in a recent fix guests now are immediately considered shut + down. Due to that the helper to shut down guests cleanly might not wait + long enough. + + * backporting the upstream fix to the affected releases. + + [Test Case] + + * Spawn a few KVM guests through libvirt, e.g. + $ uvt-simplestreams-libvirt --verbose sync --source http://cloud-images.ubuntu.com/daily arch=amd64 release=bionic label=daily + $ uvt-kvm create --memory 128 --password ubuntu b1 arch=amd64 release=bionic label=daily + $ uvt-kvm create --memory 128 --password ubuntu b2 arch=amd64 release=bionic label=daily + $ uvt-kvm create --memory 128 --password ubuntu b3 arch=amd64 release=bionic label=daily + + * A) Shut down the computer and watch how it handles guest shutdown. + + * B) You can better track that if instead of a shutdown you call what the + shutdown would via: + $ sudo /usr/lib/libvirt/libvirt-guests.sh stop + + * It will consider guests as shut down no matter what, so you might want + to modify guests to not shut down or if you have a system to do so use + huge guests with plenty of dirty memory which will slow it down. + + + [Regression Potential] + + * The fix "only" affects this shutdown handling and no other part of + libvirt which limits the ranges of potential regressions. + + * The current issue is that we don't wait enough for the geusts, we can't + wait "less" so we won't regress to be less forgiving slow-shutdowns, + but if a mistake would be in the code the regression risk would + be to slow down shutdowns - tests did not see that, but this section is + about regression POTENTIAL so I thought I add it. + + [Other Info] + + * n/a + + --- + The recent fix to libvirt-guests.sh.in works for what it intended to fix (variable scope) but failed to adapt the loop in check_guests_shutdown correctly. Due to that it currently detects all guests as "Failed to determine state of guest". It all works, but guests are just assumed dead and logs are spilled with false-positive warnings. A suggested fix is at: https://git.launchpad.net/~paelzer/libvirt/commit/?id=2ccca91678cd1091163490fd0b466b58c8be2b79
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1764668 Title: guest cleanup script fails to iterate To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1764668/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
