** Description changed:

+ [Impact]
+ Users running click-review for the first time will encounter a traceback and 
existing users will not fetch new versions of the apparmor json.
  
- Test Case
+ [Test Case]
  $ rm -f ~/.cache/click-reviewers-tools/apparmor-easyprof-ubuntu.json
- $ click-review /path/to/click 
+ $ click-review /path/to/click
+ 
+ [Regression Potential]
+ The regression potential is low since the fetching of apparmor is totally 
broken and causes a traceback.
  
  
- Original description:
+ = Original description =
  
  WARNING:root:Ignoring missing framework "ubuntu-sdk-15.04"
  Now executing: click-review ./qsa3.nessita_0.2_all.click
  Traceback (most recent call last):
    File "/usr/bin/click-review", line 162, in <module>
      main()
    File "/usr/bin/click-review", line 156, in main
      results.run_all_checks(overrides)
    File "/usr/bin/click-review", line 110, in run_all_checks
      self._run_module_checks(module, overrides)
    File "/usr/bin/click-review", line 97, in _run_module_checks
      review.do_checks()
    File "/usr/lib/python3/dist-packages/clickreviews/common.py", line 384, in 
do_checks
      func()
    File "/usr/lib/python3/dist-packages/clickreviews/cr_security.py", line 
691, in check_policy_groups
      if len(policy_groups) < 1:
  TypeError: object of type 'NoneType' has no len()
  Successfully built package in './qsa3.nessita_0.2_all.click'.
  
  This is because clickreviews/apparmor_policy.py has a link to ~click-
  reviewers instead of ~store-reviewers. This is fixed in r694

** Changed in: click-reviewers-tools (Ubuntu Xenial)
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1608943

Title:
  rename of click-reviewers LP group broke fetch of apparmor json

To manage notifications about this bug go to:
https://bugs.launchpad.net/click-reviewers-tools/+bug/1608943/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to