(In reply to Ivo Raisr from comment #31) Thank You for reviewing.
I have fixed all things that you mention. The full patch is attached, and the new version of tests is also attached. > 2) When including "tinfl.c", do we want to define "TINFL_HEADER_FILE_ONLY"? > 20) I don't see any coregrind/Makefile changes to build m_debuginfo/tinfl.c? In case we use #include "tinfl.c" without defining TINFL_HEADER_FILE_ONLY, we don't need tinfl.c in Makefile. If we include header only (by defining TINFL_HEADER_FILE_ONLY before #include) then tinfl.c needs to be compiled separately (this solution is applied in rev2 patch). > 5) CEnt.data has now non-fixed size. Why CACHE_ENTRY_SIZE is still used in > various places > around image.c; for example in alloc_CEnt() and realloc_CEnt()? CACHE_ENTRY_SIZE is still in use as default (and minimal) size of cache entry. Larger entries will be allocated in case size of the uncompressed data is grater than CACHE_ENTRY_SIZE. > However I don't have any system with toolchain supporting '-gz' at hand. > I assume you tested on MIPS. Anyone can test on a different architecture or > distribution? It seems that nobody has GCC which supports -gz, so the test is useless for now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1567219 Title: Valgrind does not support compressed debug info To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1567219/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
