The only remaining diff in php-sabre-dav-2.1 is the addition of the php- mbstring package to the test dependencies. However, the debian/tests/control lists:
Depends: @, php-curl, php-sqlite3, phpab, phpunit I wanted to confirm the test change was still needed, if php-mbstring is in the build-dependencies. '@' is a wildcard meaning 'all the binary packages from this source package'. If php-sabre-dav-2.1 depends on php-mbstring (I see that it uses mbstring functionality at runtime, not just in tests), then no separate test dependency is required. And I see that composer.json does declare that ext-mbstring is required. So this should get picked up as a dependency in phpcomposer:Debian- require. However, it does not get picked up. This is a bug somewhere between pkg-php-tools and php-mbstring. In the meantime, since the code does have a runtime dependency on mbstring, I am adding this as a hard-coded ependency in debian/control, and dropping the change to debian/tests/control which is redundant as a result. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1557599 Title: php packages: add php-mbstring dependency To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php-sabre-dav-2.1/+bug/1557599/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
