Grabbed the php-memcache package from the ppa; feedback: - you have labelled this package as '3.0.9'. However there is no upstream release 3.0.9 that I can find. If it has been released, please point me to it. If not, we should not use this version number on upstream's behalf. (For my testing, I used 3.0.8+20151130.fdbd46b, which corresponds to the current git commit.) - the contents of the orig.tar.gz unpack into a memcache-3.0.8 subdirectory, which reinforces the belief that this is not a new upstream release; you then apply a diff from debian/patches that completely removes the contents of memcache-3.0.8 and replaces them with a memcache-3.0.9 directory. This is awkward. If we are going to bump the upstream version number at all then the orig.tar.gz should contain the actual sources for that version; if we're not going to bump it then debian/patches should apply in place, not replacing one subdirectory with another. (the latter implies not updating the version string i package.xml.) - your description of the process to create the new source package is somewhat incomplete; there are references to php5 in the debian/php5* files that also need to be changed. That's fine, easily figured out and you've done this in your version of the package. - the build dependencies listed for this package are all satisfied at present in xenial, but building with the modified source package against the xenial versions of the build-deps yields an empty package containing no .so. So it appears newer versions of php-pear and/or pkg-php-tools are required before this package can be built. It is preferable to express this as a versioned build-dependency, so that we avoid accidental misbuilds.
I'll attach the source package I've generated here. Please review it and let me know if I've made any mistakes. ** Attachment added: "php-memcache_3.0.8+20151130.fdbd46b.orig.tar.xz" https://bugs.launchpad.net/ubuntu/+source/php-memcache/+bug/1543349/+attachment/4569853/+files/php-memcache_3.0.8+20151130.fdbd46b.orig.tar.xz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1543349 Title: upgrade php-memcache for PHP7.0 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php-memcache/+bug/1543349/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
