Hi Michael,

I'm trying to understand this patch, one of your changes is to not
require the /drm/card* suffix on the syspath. Do you know why this was
there before? Does it matter it's not checked for now?

The replacement of "end - 13" with skipping the prefix seems much safer.
You could also drop the "end" variable as it's no longer used. I would
also be nicer to replace the 19 magic number with a strlen
("/devices/pci/0000:00") although this is also unsafe and could run you
off the end of the array. I'm happy to make these changes if you don't
want to.


** Bug watch added: freedesktop.org Bugzilla #77889
   https://bugs.freedesktop.org/show_bug.cgi?id=77889

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1492175

Title:
  drm_device_keep_trying.patch breaks with virtio-gpu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xserver-xorg/+bug/1492175/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to