@Egmont: The bug is asking for highlighting of a string, not necessarily
all of them at once, because right now the search has no highlight,
making it hard for the eye to find the text.

I did some digging through how the search works in GNOME Terminator, and
realised that for some reason the implementation in Terminator does it's
own searching through the buffer rather than simply using the vte
gregex/next/previous stuff. It's quite a chunk of code and I'd like
to/will fix it, but it's not a five minute job. Once we start using that
built-in function, then we will get highlighting, and it will simplify
that whole section of Python code.

Of course it would be nice to highlight all matches at once like "less".
Having said that, can I make a sly request (ulterior motives ;-) that
rather than just extending vte to highlight the search matches, a
generic API way to adjust formatting of any part of the scrollback
buffer text temporarily is created as part of it? ClusTerm (v.old Perl
program that also used vte) used to have a highlight differences
feature. It worked by copying the text out, and then overwriting text
with new attributes, which is really ugly and buggy.

@all the +1, me too, etc comments : Please don't do that. At the very
top there is a link for indicating that this affects you. If you can't
contribute useful information, or code, there is no need to post a
comment.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/271487

Title:
  terminator need to highlight search string

To manage notifications about this bug go to:
https://bugs.launchpad.net/terminator/+bug/271487/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to