I'm still confused - if possible please give a concise answer (with no
other context) - is the patch which I am pasting below all that is
needed? Should that patch be sent upstream?
------- Comment From thierry.fa...@fr.ibm.com 2015-04-08 07:54 EDT-------
Commit 573609fb2711b6c09090cc3fef9a771ae9eb246b sent to maintainers
>From 573609fb2711b6c09090cc3fef9a771ae9eb246b Mon Sep 17 00:00:00 2001
From: Thierry FAUCK - IBM LTC <thie...@linux.vnet.ibm.com>
Date: Tue, 7 Apr 2015 17:53:34 +0200
Subject: [PATCH] libnuma.so On ppc64el, cpu number are not contigous
Commit 32075635db57c3d5efe12f8fb569af857e01ccad issuea warning message
/sys not mounted when it find a non existent cpu number, and that's the
default for multinode on ppc64el bare metal installed system. This patch
removes the message when the /sys entry doesn't exist, but use the return
code.
Signed-off-by: Thierry FAUCK - IBM LTC <thie...@linux.vnet.ibm.com>
modified: libnuma.c
---
libnuma.c | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/libnuma.c b/libnuma.c
index 3717d5b..98aa10f 100644
--- a/libnuma.c
+++ b/libnuma.c
@@ -1276,11 +1276,13 @@ numa_node_to_cpus_v1(int node, unsigned long *buffer,
int bufferlen)
sprintf(fn, "/sys/devices/system/node/node%d/cpumap", node);
f = fopen(fn, "r");
if (!f || getdelim(&line, &len, '\n', f) < 1) {
- numa_warn(W_nosysfs2,
- "/sys not mounted or invalid. Assuming one node: %s",
+ if (f) {
+ numa_warn(W_nosysfs2,
+ "/sys not mounted or invalid. Assuming one node: %s",
strerror(errno));
- numa_warn(W_nosysfs2,
- "(cannot open or correctly parse %s)", fn);
+ numa_warn(W_nosysfs2,
+ "(cannot open or correctly parse %s)", fn);
+ }
bitmask.maskp = (unsigned long *)mask;
bitmask.size = buflen_needed * 8;
numa_bitmask_setall(&bitmask);
@@ -1355,11 +1357,13 @@ numa_node_to_cpus_v2(int node, struct bitmask *buffer)
sprintf(fn, "/sys/devices/system/node/node%d/cpumap", node);
f = fopen(fn, "r");
if (!f || getdelim(&line, &len, '\n', f) < 1) {
- numa_warn(W_nosysfs2,
- "/sys not mounted or invalid. Assuming one node: %s",
- strerror(errno));
- numa_warn(W_nosysfs2,
- "(cannot open or correctly parse %s)", fn);
+ if (f) {
+ numa_warn(W_nosysfs2,
+ "/sys not mounted or invalid. Assuming one node: %s",
+ strerror(errno));
+ numa_warn(W_nosysfs2,
+ "(cannot open or correctly parse %s)", fn);
+ }
numa_bitmask_setall(mask);
err = -1;
}
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1358835
Title:
numa_node_of_cpu() returns warning when cpu_index > 79
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/numactl/+bug/1358835/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
