Comment on attachment 8584608
Unified patch (code + test changes + three times revised new test)
Review of attachment 8584608:
-----------------------------------------------------------------
Can you please revise the commit message to explain what the patch does?
Something like: "Bug 756984 - Collapse the selection on the last text
node on the line, skipping br and inline frames when clicking past the
end of line; r=roc,ehsan".
Thanks again! Once you address these nits, this is ready to be checked
in.
::: layout/generic/test/test_bug756984.html
@@ +43,5 @@
> + is(selRange.endContainer.nodeName, "#text", "selection should be in
> text node");
> + is(selRange.endOffset, 3, "offset should be 3");
> + }
> +
> + // click beyond the second line (100px to the left and 2px down),
> expect DIV.
Nit: please make this "first line".
@@ +47,5 @@
> + // click beyond the second line (100px to the left and 2px down),
> expect DIV.
> + // This is the previous behaviour which hasn't changed since the line
> is empty.
> + // If the processing were wrong, the selection would end up in the
> preceing non-empty line.
> + theDiv = document.getElementById("div4");
> + sel = window.getSelection();
Nit: this is not needed.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/584632
Title:
composer changes font mid email
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
