Launchpad has imported 38 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=765803.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2012-06-18T17:01:11+00:00 Jbg-w wrote: User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.142 Safari/535.19 Steps to reproduce: Reply to a message with the "reply above" option set Actual results: TB used to include at least one blank line before the reply section, now it jams the reply right up against the first line of the reply area. Expected results: Leave at least one blank line, or make the amount of space configurable. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/0 ------------------------------------------------------------------------ On 2012-06-18T23:04:06+00:00 Rsx11m-pub wrote: *** Bug 765826 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/1 ------------------------------------------------------------------------ On 2012-06-18T23:10:10+00:00 Rsx11m-pub wrote: Looks like a regression in the 13.0 HTML editor, possibly introduced with the new filelink feature. Steps to reproduce: 1. Compose in HTML mode 2. Don't have a signature defined 3. Set "reply above quote" Clicking reply inserts two blank lines above the reply header in 10.0.5 ESR and places the cursor to the first one. On 14.0a2, there is only a single blank line above the <div class="moz-cite-prefix"> node. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/2 ------------------------------------------------------------------------ On 2012-06-18T23:17:45+00:00 Rsx11m-pub wrote: Plain-text composition doesn't appear to be affected. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/3 ------------------------------------------------------------------------ On 2012-06-26T06:31:28+00:00 hashemmasoud wrote: *** Bug 768292 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/4 ------------------------------------------------------------------------ On 2012-06-26T14:55:34+00:00 Rsx11m-pub wrote: *** Bug 767752 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/5 ------------------------------------------------------------------------ On 2012-07-09T16:29:56+00:00 Nixon049 wrote: This occurs even if a signature is defined, so long as signature is placed below the quote. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 ID:20120614161456 Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/9 ------------------------------------------------------------------------ On 2012-07-13T16:41:31+00:00 Jake1138 wrote: I noticed this recently too. I am running 13.0.1. I hope this gets fixed soon. It's really annoying. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/14 ------------------------------------------------------------------------ On 2012-07-13T17:20:34+00:00 Alice0775 wrote: Regression window Good: http://hg.mozilla.org/comm-central/rev/3ad9c88900d6 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120313 Thunderbird/13.0a1 ID:20120313030025 Bad: http://hg.mozilla.org/comm-central/rev/1593bfcee4fb Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120314 Thunderbird/14.0a1 ID:20120314030025 Pushlog: http://hg.mozilla.org/comm-central/pushloghtml?fromchange=3ad9c88900d6&tochange=1593bfcee4fb Suspected : Bug 735380 Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/15 ------------------------------------------------------------------------ On 2012-09-05T07:02:53+00:00 Brian Norris wrote: I can confirm that this bug still exists in 15.0. I'm using Ubuntu 12.04. This issue has been reported on the Ubuntu launchpad tracker: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813 Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/16 ------------------------------------------------------------------------ On 2012-09-28T01:10:26+00:00 Thorokol wrote: I am using 15.0.1 and I've been waiting for many versions for this to be fixed. I've been using Thunderbird since the very beginning and this is very annoying as it only got introduced into TB a few versions ago. Please fix this. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/17 ------------------------------------------------------------------------ On 2012-11-29T22:39:48+00:00 Toban57 wrote: I'm running Thunderbird 17.0, portable on XP, and this is STILL an issue. Does not look like they are working on this bug too hard. Very annoying! Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/18 ------------------------------------------------------------------------ On 2012-11-29T22:44:20+00:00 Toban57 wrote: I'm running Thunderbird 17.0, portable on XP, and this is STILL an issue. Does not look like they are working on this bug too hard. Very annoying! Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/19 ------------------------------------------------------------------------ On 2012-11-29T22:45:34+00:00 Toban57 wrote: I'm running Thunderbird 17.0, portable on XP, and this is STILL an issue. Does not look like they are working on this bug too hard. Very annoying! Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/20 ------------------------------------------------------------------------ On 2012-11-29T22:50:39+00:00 Toban57 wrote: Sorry about the multiple posts. Not sure how to delete the two duplicates. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/21 ------------------------------------------------------------------------ On 2012-11-30T01:57:48+00:00 Antoine-mechelynck-gmail wrote: (In reply to Toby Banner from comment #14) > Sorry about the multiple posts. Not sure how to delete the two duplicates. You can't. Just be more careful next time. :-) Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/22 ------------------------------------------------------------------------ On 2012-12-02T07:51:02+00:00 Brian Norris wrote: Created attachment 687497 Path: adds back a newline for HTML replies Since there's been no real help from Mozilla, I'm posting my own fix. This fixes the worst annoyance -- the missing newline at the start of HTML, reply-on-top mail -- but it still leaves a seemingly-extraneous newline below the quote. Please at least give this a look. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/23 ------------------------------------------------------------------------ On 2013-03-23T08:07:36+00:00 Brian Norris wrote: Bump! Mike, can you take a look at this? Or shall I find a different reviewer? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/24 ------------------------------------------------------------------------ On 2013-03-23T14:11:36+00:00 Mike Conley wrote: Created attachment 728622 Test fix This test needs to be modified in order to accommodate the new patch. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/25 ------------------------------------------------------------------------ On 2013-03-23T14:13:28+00:00 Mike Conley wrote: Comment on attachment 687497 Path: adds back a newline for HTML replies Review of attachment 687497: ----------------------------------------------------------------- This appears to fix the described problem, although it breaks one of the Filelink tests (which I've added a patch to address). So I like this! I think we'll need to request review from the SM folks, since this is a mailnews change. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/26 ------------------------------------------------------------------------ On 2013-03-23T14:16:57+00:00 Mike Conley wrote: Comment on attachment 728622 Test fix We've added an extra line break, so we have to modify one of the tests to accommodate it. Blake, you originally reviewed these tests...does this look OK to you? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/27 ------------------------------------------------------------------------ On 2013-03-23T19:40:33+00:00 Johnvorhaus wrote: Is there any fix available as an ADD-IN or a SETTING CHANGE? I'm lost in code and am look for something even a STOOPID person can master. Thanks. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/28 ------------------------------------------------------------------------ On 2013-03-23T20:21:23+00:00 Brian Norris wrote: (In reply to johnvorhaus from comment #21) > Is there any fix available as an ADD-IN or a SETTING CHANGE? I'm lost in > code and am look for something even a STOOPID person can master. Thanks. Hi John (forgive me if that is not your name), This fix is seemingly making progress toward being included in an upcoming Thunderbird release, and so it will not need an add-on or other workaround. Please be patient, and hopefully this regression will be squashed! If, however, you want an immediate solution, I did find a workaround that sorta works (it fixes HTML mail but adds an *extra* newline for plain text mail) here: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/5 Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/29 ------------------------------------------------------------------------ On 2013-03-29T07:47:36+00:00 Brian Norris wrote: Just a ping: any responses from Neil or Blake on the bugfix + test case? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/30 ------------------------------------------------------------------------ On 2013-04-01T17:04:04+00:00 Bwinton-a wrote: Comment on attachment 728622 Test fix Yeah, this change seems okay to me, assuming it makes the test pass… Thanks, Blake. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/31 ------------------------------------------------------------------------ On 2013-04-11T04:57:36+00:00 Brian Norris wrote: Ping: Neil, can you review the bugfix patch? If not, what's the next step? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/32 ------------------------------------------------------------------------ On 2013-06-19T18:15:25+00:00 Josiah-l wrote: Neil seems pretty busy. IanN, do you have a few to review this? (Looks like this is your area) Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/35 ------------------------------------------------------------------------ On 2013-12-05T11:35:05+00:00 Pf4public wrote: Any news on this? Tried user.js with // Modify quote header // user_pref("mailnews.reply_header_ondate", "\nOn %s"); but it does not help TB version 24.1.1 Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/36 ------------------------------------------------------------------------ On 2014-03-20T22:45:30+00:00 Louiserbaldwin wrote: Small patch to fix major annoyance is just waiting review for the past year. Come on, ladies and gentlemen. How can we find someone to review this? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/37 ------------------------------------------------------------------------ On 2014-03-20T22:52:50+00:00 Josiah-l wrote: Neil, could you please review this quickly? It's a two liner. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/38 ------------------------------------------------------------------------ On 2014-04-13T15:24:05+00:00 Pf4public wrote: Obviously, it is way too difficult to fix this :( Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/39 ------------------------------------------------------------------------ On 2014-06-18T07:00:14+00:00 Brian Norris wrote: Time for an annual checkup here. Anyone listening? Can the provided patch be applied? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/40 ------------------------------------------------------------------------ On 2014-06-18T13:48:24+00:00 Josiah-l wrote: If I can't get Neil to look at this later today then I think Mike or myself could probably just review it. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/41 ------------------------------------------------------------------------ On 2014-06-20T06:45:46+00:00 Brian Norris wrote: (In reply to Josiah Bruner [:JosiahOne] from comment #32) > If I can't get Neil to look at this later today then I think Mike or myself > could probably just review it. It's past "later today" on all parts of the globe ;) Can you or Mike take a look please? FWIW, I retested against the latest, and everything patches and runs as expected. (Now that I'm revisiting the history, it looks like Mike already added his "review+", which I think means my patch was officially "reviewed." But then he pushed it back to Neil, who hasn't responded. Can we just finish this off already?) Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/42 ------------------------------------------------------------------------ On 2014-06-20T09:54:33+00:00 Neil-httl wrote: Comment on attachment 687497 Path: adds back a newline for HTML replies Sorry for dropping the ball on this. Editor is a bit strange when it comes to breaks, in particular you need a break in an empty block so that you can put the caret there, so it creates a bogus break to achieve this. However when you insert a break (e.g. by pressing Enter in an empty Compose window) this bogus break gets deleted, and the net result is that nothing happens, which is unhelpful. Inserting a break by pressing Shift+Enter does force the insert of a break without deleting the bogus break, but there's no direct function to achieve this, and the one API point we have behaves differently in plain text compose. So I think the best solution here is to move this extra break to the beginning of the if (reply_on_top == 1) block, with a suitable comment to the effect that the HTML editor eats the initial break. (On an unrelated note, the code to detect a signature is over-engineered - any signature is already in aSignature at this point.) Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/43 ------------------------------------------------------------------------ On 2014-07-05T21:44:27+00:00 Brian Norris wrote: (In reply to n...@parkwaycc.co.uk from comment #34) > So I think the best solution here is to move this extra break to the > beginning of the if (reply_on_top == 1) block, with a suitable comment to > the effect that the HTML editor eats the initial break. So you'd like essentially the same patch, just moved around and with an extra comments? I'll respin, retest, and flag you for review shortly. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/44 ------------------------------------------------------------------------ On 2014-07-05T23:09:13+00:00 Brian Norris wrote: Created attachment 8451310 Patch: adds back a newline for HTML replies (version 2) Adding version 2 patch. Essentially the same, refactorerd to address comments. Please review, Neil. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/45 ------------------------------------------------------------------------ On 2014-11-07T13:54:45+00:00 Patrick Cloke wrote: https://hg.mozilla.org/comm-central/rev/e1e1955cce9c https://hg.mozilla.org/comm-central/rev/64e49d15dff7 Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/46 ** Changed in: thunderbird Status: Unknown => Fix Released ** Changed in: thunderbird Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1021813 Title: Thunderbird places incorrect newlines when composing a reply using "reply above quote" To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/1021813/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
