Launchpad has imported 19 comments from the remote bug at
https://bugzilla.xfce.org/show_bug.cgi?id=6663.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2010-08-25T05:12:32+00:00 Mathias Brodala wrote:

Since Thunar itself now uses Gio and Udev for device handling, the
places plugin should follow and use the same framework. This would make
the dependency on ThunarVFS obsolete and would allow me to get rid of
HAL for good.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/4

------------------------------------------------------------------------
On 2010-09-01T04:06:55+00:00 Diego Ongaro wrote:

*** Bug 6674 has been marked as a duplicate of this bug. ***

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/5

------------------------------------------------------------------------
On 2010-09-01T04:09:37+00:00 Diego Ongaro wrote:

Yes, you're absolutely right, places needs to be ported over. Let me
know if you want to work on this; my time for the project has been quite
limited lately.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/6

------------------------------------------------------------------------
On 2010-09-01T06:21:39+00:00 Yves-Alexis Perez wrote:

Damn, bugzilla (and/or me) really has searches issues. Sorry for
duplicate.

No I don't really have time to port it (I barely have time to maintain
Xfce stuff these days) but thought it'd be nice to track it, except I
didn't see it was already tracked.

For people interested, it might be worth giving some infos about the
current state (how it is done at the moment) and how it should be done
in a Gio world (the latter needing info from people aware, maybe Jannis
could give some doc?)

Cheers and thanks for your work.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/7

------------------------------------------------------------------------
On 2010-09-01T10:10:42+00:00 Jannis Pohlmann wrote:

I haven't looked at the code yet but I remember the plugin vaguely and
it should be as simple as replacing the portions of code related to
thunar-vfs with usages of GIO. I don't think there's anything special
(like integrating udev) that needs to be taken care of.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/8

------------------------------------------------------------------------
On 2010-12-11T10:56:13+00:00 Lionel Le Folgoc wrote:

*** Bug 6966 has been marked as a duplicate of this bug. ***

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/9

------------------------------------------------------------------------
On 2010-12-11T15:56:52+00:00 Frivoal-m wrote:

I use places myself, so I'll be sure to get to this eventually. But if
someone can contribute a patch before I get there, that would be great.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/10

------------------------------------------------------------------------
On 2011-02-22T00:04:49+00:00 Jan Rękorajski wrote:

Created attachment 3497
port to gio

Here is the patch :)
Please check and test, this patch is a shameless rip from xfdesktop.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/13

------------------------------------------------------------------------
On 2011-02-22T17:08:56+00:00 Mathias Brodala wrote:

(In reply to comment #7)
> Created attachment 3497 [details]
> port to gio
> 
> Here is the patch :)
> Please check and test, this patch is a shameless rip from xfdesktop.

What to apply this patch to? Neither the latest 1.2.0 nor the latest git
seems to work. Here’s the output from trying to patch the git version:

patching file config.h.in
Hunk #2 succeeded at 67 with fuzz 2 (offset 4 lines).
Hunk #3 succeeded at 92 with fuzz 2 (offset 7 lines).
patching file configure.in
Hunk #1 FAILED at 15.
1 out of 1 hunk FAILED -- saving rejects to file configure.in.rej
patching file panel-plugin/Makefile.am
Hunk #3 FAILED at 47.
1 out of 3 hunks FAILED -- saving rejects to file panel-plugin/Makefile.am.rej
patching file panel-plugin/model.h
patching file panel-plugin/model_system.c
patching file panel-plugin/model_user.c
patching file panel-plugin/model_volumes.c
Hunk #5 FAILED at 405.
Hunk #6 succeeded at 420 (offset 3 lines).
Hunk #7 succeeded at 474 (offset 3 lines).
Hunk #8 succeeded at 484 (offset 3 lines).
Hunk #9 succeeded at 518 (offset 3 lines).
Hunk #10 succeeded at 540 (offset 3 lines).
Hunk #11 succeeded at 548 (offset 3 lines).
1 out of 11 hunks FAILED -- saving rejects to file 
panel-plugin/model_volumes.c.rej
patching file panel-plugin/model_volumes_notify.c
patching file panel-plugin/model_volumes_notify.h
patching file panel-plugin/view.c
Hunk #1 succeeded at 59 (offset 2 lines).
Hunk #2 succeeded at 69 (offset 2 lines).
Hunk #3 succeeded at 458 (offset 2 lines).
Hunk #4 FAILED at 541.
Hunk #5 succeeded at 950 (offset -10 lines).
1 out of 5 hunks FAILED -- saving rejects to file panel-plugin/view.c.rej
patching file panel-plugin/xfce46-compat.c
patching file panel-plugin/xfce46-compat.h

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/14

------------------------------------------------------------------------
On 2011-02-23T21:36:49+00:00 Jan Rękorajski wrote:

Created attachment 3507
patch for clean 1.2.0

This patch applies to clean 1.2.0 sources.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/15

------------------------------------------------------------------------
On 2011-02-23T21:38:13+00:00 Jan Rękorajski wrote:

(In reply to comment #8)
> (In reply to comment #7)
> > Created attachment 3497 [details]
> > port to gio
> > 
> > Here is the patch :)
> > Please check and test, this patch is a shameless rip from xfdesktop.
> 
> What to apply this patch to? Neither the latest 1.2.0 nor the latest git seems
> to work. Here’s the output from trying to patch the git version:
> 

It applies to 1.2.0 on top of exo-1 (id:5754) and libxfce4ui (id:7317) patches.
I added a patch for clean 1.2.0 sources.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/16

------------------------------------------------------------------------
On 2011-05-26T19:36:42+00:00 sledgehammer999 wrote:

Would you guys be interested in a complete rewrite instead? (using C++
and gtkmm/glibmm)

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/17

------------------------------------------------------------------------
On 2011-05-26T19:39:26+00:00 Yves-Alexis Perez wrote:

(In reply to comment #11)
> Would you guys be interested in a complete rewrite instead? (using C++ and
> gtkmm/glibmm)

Definitely not.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/18

------------------------------------------------------------------------
On 2011-05-26T19:41:28+00:00 Jannis Pohlmann wrote:

Let's put it this way: we don't use C++ anywhere in Xfce core, so if it
can be avoided, extensions should be written without additional
dependencies/libraries to be loaded.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/19

------------------------------------------------------------------------
On 2011-05-26T20:14:58+00:00 sledgehammer999 wrote:

Ok. I totally get Jannis Pohlmann's reasons. But from Yves-Alexis
Perez's reply I have to ask this. Is the Xfce's team stance against
C++(in general) the same as the Gnome's/Gtk's team? (not exactly hating
it but not actively supporting it etc etc)

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/20

------------------------------------------------------------------------
On 2011-05-26T20:21:11+00:00 Yves-Alexis Perez wrote:

(In reply to comment #14)
> Ok. I totally get Jannis Pohlmann's reasons. But from Yves-Alexis Perez's 
> reply
> I have to ask this. Is the Xfce's team stance against C++(in general) the same
> as the Gnome's/Gtk's team? (not exactly hating it but not actively supporting
> it etc etc)

(note that I'm not in the Xfce team, not as an active developer at
least, I'm a Debian maintainer)

As Jannis said, the whole Xfce stack uses C/GTK+. C++ and Gtkmm looks to
me more like a cludge.

Personally, I'm really not a huge fan of C++, but there are people using
Vala, in case you'd  be interested.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/21

------------------------------------------------------------------------
On 2011-05-26T20:30:11+00:00 Jannis Pohlmann wrote:

We evenhave our own GLib/GTK+ C++ bindings but they are not really
actively maintained, I think, and they are not used anywhere. We also
don't use glibmm/gtkmm anywhere as it makes little sense for us.

The benefit of C++ over C is rather small overall.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/22

------------------------------------------------------------------------
On 2011-05-26T20:33:27+00:00 sledgehammer999 wrote:

I'd love to continue this but I don't want to pollute the bug report. 
For now, I hope that the patch gets finally in git. It seems to work fine in 
Debian. But before that please clean up the code that is related to this report 
of mine: https://bugzilla.xfce.org/show_bug.cgi?id=7666

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/23

------------------------------------------------------------------------
On 2014-11-23T20:43:07+00:00 Landry-o wrote:

Mass-reassign all bugs from florian@ to goodies-dev@, thanks for the
maintenance work! (and sorry for the bugmail spam..)

Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-places-
plugin/+bug/136940/comments/30


** Changed in: xfce4-places-plugin
       Status: Unknown => Confirmed

** Changed in: xfce4-places-plugin
   Importance: Unknown => Wishlist

** Bug watch added: Xfce Bugzilla #7666
   https://bugzilla.xfce.org/show_bug.cgi?id=7666

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/136940

Title:
  should allow opening non-removable partitions (port to Gio)

To manage notifications about this bug go to:
https://bugs.launchpad.net/xfce4-places-plugin/+bug/136940/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to