Created attachment 8426804
Implement size for recording surface created for windows printing

Ok, confirmed that it's still broken on beta.

It appears that for windows printing we create a gfxWindowsSurface that
is backed by a cairo recording surface. So when we call
CreateSimilarSurface, we end up with a gfxUnknownSurface (since we don't
have a c++ class for recording surfaces).

GetSize() isn't implemented for gfxUnknownSurface and we hit the same
bug as before.

This patch seems like the most unobtrusive way to fix this, especially
since we're pushing towards using Moz2D directly everywhere.

I guess the *right* fix would be to add gfxRecordingSurface, and to
expose new cairo API to obtain the size from a
cairo_recording_surface_t. I don't think that's worth doing for code we
want to get rid of.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1315020

Title:
  PDF.js prints blank pages

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1315020/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to