I'm afraid I'm not at all happy with this patch, for the following reasons:
1) I tend to agree with Phillip that the meaning is sufficiently different that it's misleading; "standard" names tend to come with expectations of standard user interfaces, standard facilities provided, etc. which aren't going to be satisfiable here. 2) Introducing new distribution-specific configuration keys has to be done with great care in general, and this name is particularly verbose. 3) Changing /etc/default/grub may well result in configuration file prompts for many people on upgrade; I avoid it wherever possible. 4) What do we do when the next customer comes along with a similar but different requirement? We can't carry on stacking yes-or-no configuration options on top of each other. 5) It isn't complete; there are mentions of "recovery mode" elsewhere, and the new variable isn't documented in the info documentation. That said, I understand that this is a customer requirement so it looks like I don't have much option but to add a distribution-specific key. I think the least bad option here is to add a GRUB_RECOVERY_TITLE option, so you can set GRUB_RECOVERY_TITLE="safe mode"; that avoids the potential problem of stacking different options, and doesn't assign any particular credit to the name that the customer wants to use here. I'll take care of doing that and of making sure that the patch is complete. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1240360 Title: Rename boot option from "recovery mode" to "safe mode" in GRUB menu To manage notifications about this bug go to: https://bugs.launchpad.net/grub/+bug/1240360/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
