(In reply to n...@parkwaycc.co.uk from comment #10)
> Comment on attachment 755964
> updated for comments
> 
> >+  mLastModified: null,
> Not sure how this change relates.
it needs to be cached in case of a cancel, it would break new refreshes if set 
prior to full completion.
> 
> >-      win.updateStatusItem("statusText", message, aErrorCode);
> >+      let code = feed.url.startsWith("http") ? aErrorCode : null;
> >+      win.updateStatusItem("statusText", message, code);
> Not sure how this change relates.
> 

the validation link makes no sense unless http, so hide it otherwise.

> >-        onunload="return FeedSubscriptions.onUnload();"
> >+        onclose="return FeedSubscriptions.onClose();"
> Not sure how this change relates.

comment 3.
> 
> >+  HIGH_COUNT_LIMIT_SUBSCRIBE: 200,
> >+  HIGH_COUNT_LIMIT_UPDATE: 1000,
> >+  CANCEL_REQUESTED: false,
> What happens when there are too many items? (By comparison, for newsgroups,
> you can choose to either download the latest N (ignoring the rest) or the
> next N, although I don't know whether the RSS code would be able to let you
> do this. Also, N is pref-controlled, although we can leave that to a
> separate bug.)
> Also, wouldn't it be more likely for there to be many items when you first
> subscribe? (I know a feed that only used to update every few days or so but
> the RSS feed contained the entire archive should you so want it.)
> 

the server based newsgroup model doesn't work for feeds.  imo 2 prefs
are very not worth it.  in all cases, the user decides, and this is to
really prevent surprises.

> >+  confirmHighItemCount: function(aFeed, aCount) {
> Where does this actually get called?

bad patch before..

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/191006

Title:
  Thunderbird RSS should have a per feed limit per download

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/191006/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to