This patch simply deletes the option.  I left the function itself in
place to hopefully keep the patch applicable for future releases.


** Description changed:

- Shouldn't automatic updates be disabled, as with other packages (e.g.
- Firefox) ?
+ [Impact]
+ The --update option downloads content from a third party site (a URL 
hardcoded in the script) and then copies it into /usr/bin/youtube-dl.  This is 
unsafe.
  
- salisbury:~$ ls -l /usr/bin/youtube-dl; md5sum /usr/bin/youtube-dl 
+ Unfortunately, the --update option is extraordinarily handy since
+ youtube frequently changes its web interface, which breaks the script.
+ Indeed the version of youtube-dl currently in Precise is broken as of
+ Nov 4, 2012 and can't retrieve videos.  Running youtube-dl --update
+ fixes this by installing a new version of the script.  However this new
+ script is a binary executable.
+ 
+ [Test Case]
+ $ ls -l /usr/bin/youtube-dl; md5sum /usr/bin/youtube-dl; file 
/usr/bin/youtube-dl
  -rwxr-xr-x 1 root root 159848 Feb 27  2012 /usr/bin/youtube-dl*
  bd2f1db2f3edafcbf207fab805d36e23  /usr/bin/youtube-dl
- salisbury:~$ sudo youtube-dl --update
- [sudo] password for bryce: 
+ /usr/bin/youtube-dl: a python script, UTF-8 Unicode text executable
+ 
+ $ sudo youtube-dl --update
+ [sudo] password for XXX:
  Updating to latest version...
  Updated youtube-dl. Restart youtube-dl to use the new version.
- salisbury:~$ ls -l /usr/bin/youtube-dl; md5sum /usr/bin/youtube-dl 
+ 
+ $ ls -l /usr/bin/youtube-dl; md5sum /usr/bin/youtube-dl; file 
/usr/bin/youtube-dl
  -rwxr-xr-x 1 root root 43730 Nov  4 20:50 /usr/bin/youtube-dl*
  02c2a961099f067a8595ac771baed12a  /usr/bin/youtube-dl
+ /usr/bin/youtube-dl: data
  
+ [Regression Risk]
+ The patch removes code (and functionality), so doesn't risk new bugs.  The 
loss of functionality is intentional to fix this issue.
+ 
+ [Original Report]
+ Shouldn't automatic updates be disabled, as with other packages (e.g. 
Firefox) ?
  
  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: youtube-dl 2012.02.27-1 [modified: usr/bin/youtube-dl]
  ProcVersionSignature: Ubuntu 3.2.0-31.50-generic-pae 3.2.28
  Uname: Linux 3.2.0-31-generic-pae i686
  ApportVersion: 2.0.1-0ubuntu13
  Architecture: i386
  Date: Mon Oct  8 02:04:53 2012
  PackageArchitecture: all
  ProcEnviron:
   LANGUAGE=fr_FR:en
   TERM=xterm
   PATH=(custom, no user)
   LANG=fr_FR.UTF-8
   SHELL=/bin/bash
  SourcePackage: youtube-dl
  UpgradeStatus: Upgraded to precise on 2012-04-27 (164 days ago)

** Patch added: "youtube-dl_2012.02.27-1ubuntu1.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/youtube-dl/+bug/1063469/+attachment/3424337/+files/youtube-dl_2012.02.27-1ubuntu1.debdiff

** Changed in: youtube-dl (Ubuntu Precise)
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1063469

Title:
  Disable --update option

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/youtube-dl/+bug/1063469/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to