tl;dr The current code should be correct.

old naming = blah-pid
new naming = blah.pid
That was changed upstream in:
http://code.google.com/p/pylockfile/source/detail?r=102
That was released upstream in 0.9.1

But nova overrides lockfile naming since essex-1-2022-geb42e7f
The new regexp is correct for that.
I.E. diablo lock files and named depending on lockfile version,
but diablo doesn't have the cleaning code, so that is moot.

p.s. This cleanup code doesn't work on windows I think,
as it's assuming file rather than directory locks.
Maybe os.link is available on windows but I don't think
it's available in python yet.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1018586

Title:
  cleanup_file_locks does not remove stale sentinel files

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1018586/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to