Public bug reported:

I just finished packaging display-dhammapada for Fedora and so went
through this package.

1. The man page needs updating as it contains undefined macros and dead
links / url.

Here are the patches for display-dhammapada.1 :

--- display-dhammapada-0.23/display-dhammapada.1        2003-08-13 
11:56:31.000000000 -0600
+++ display-dhammapada-0.23-fedora/display-dhammapada.1 2012-06-15 
22:00:40.090200049 -0600
@@ -1,6 +1,5 @@
 .\" -*- coding: UTF-8 -*-
-.DD April 13, 2003
-.TH DISPLAY-DHAMMAPADA 1  "late 20th - early 21th century"
+.TH DISPLAY-DHAMMAPADA 1  "April 2003" "0.23" "display-dhammapada man page"
 .SH NAME
 display-dhammapada \- display a verse from the Dhammapada
 .SH SYNOPSIS
@@ -73,7 +72,7 @@
 
 .fi
 .\" $bash1$ display-dhammapada -r all |perl -0777 -pe 's/\n\s*\n\s*\n/\n%\n/g' 
>~/.kde/share/apps/amor/tips
-.Ed
+.P
 Then start amor K->Toys->Amor, right click on amor animation, select "Options" 
and check "Show random tips".
 .SH FILES
 .I /usr/local/share/display-dhammapada/dhammapada-english-transl.txt
@@ -87,11 +86,12 @@
 .SH AUTHORS
 Program: Copyright \(co 1997-2003 Richard Cepas, placed in the public domain.
 .br
-See http://www.angelfire.com/me/rch/dd.html
+See http://unicode.strangled.net/me/rch/dd.html
 .P
 Richards' English translation of the Dhammapada: Copyright (C) 1993 John
 Richards, Pembrokeshire (UK), permission granted for use here.
-See 
ftp://coombs.anu.edu.au/coombspapers/otherarchives/electronic-buddhist-archives/buddhism-general/e-texts/sutras-translations/dhammapada-english-transl.txt
+./" Old link - See 
ftp://coombs.anu.edu.au/coombspapers/otherarchives/electronic-buddhist-archives/buddhism-general/e-texts/sutras-translations/dhammapada-english-transl.txt
+See http://eawc.evansville.edu/anthology/dhammapada.htm - John Richards 
(19.Oct.1993)
 .P
 Muller's translation of the Dhammapada: Public Domain, used here courtesy of
 Project Gutenberg. 


And display-dhammapada.1.in :
--- display-dhammapada-0.23/display-dhammapada.1.in     2003-08-13 
10:23:50.000000000 -0600
+++ display-dhammapada-0.23-fedora/display-dhammapada.1.in      2012-06-15 
22:39:39.631166846 -0600
@@ -1,6 +1,5 @@
 .\" -*- coding: UTF-8 -*-
-.DD April 13, 2003
-.TH DISPLAY-DHAMMAPADA 1  "late 20th - early 21th century"
+.TH DISPLAY-DHAMMAPADA 1  "April 2003" "0.23" "display-dhammapada man page"
 .SH NAME
 display-dhammapada \- display a verse from the Dhammapada
 .SH SYNOPSIS
@@ -73,7 +72,7 @@
 
 .fi
 .\" $bash1$ display-dhammapada -r all |perl -0777 -pe 's/\n\s*\n\s*\n/\n%\n/g' 
>~/.kde/share/apps/amor/tips
-.Ed
+.P
 Then start amor K->Toys->Amor, right click on amor animation, select "Options" 
and check "Show random tips".
 .SH FILES
 .I /usr/share/display-dhammapada/dhammapada-english-transl.txt
@@ -87,11 +86,12 @@
 .SH AUTHORS
 Program: Copyright \(co 1997-2003 Richard Cepas, placed in the public domain.
 .br
-See http://www.angelfire.com/me/rch/dd.html
+See http://unicode.strangled.net/me/rch/dd.html
 .P
 Richards' English translation of the Dhammapada: Copyright (C) 1993 John
 Richards, Pembrokeshire (UK), permission granted for use here.
-See 
ftp://coombs.anu.edu.au/coombspapers/otherarchives/electronic-buddhist-archives/buddhism-general/e-texts/sutras-translations/dhammapada-english-transl.txt
+.\" Old link - See 
ftp://coombs.anu.edu.au/coombspapers/otherarchives/electronic-buddhist-archives/buddhism-general/e-texts/sutras-translations/dhammapada-english-transl.txt
+See http://eawc.evansville.edu/anthology/dhammapada.htm - John Richards 
(19.Oct.1993)
 .P
 Muller's translation of the Dhammapada: Public Domain, used here courtesy of
-Project Gutenberg. 
+Project Gutenberg.

I will add those as attachments.

2. When reviewing the package, the Makefile appears to be intended to be
run as root. This is sort of outdated as most packaging is done as users
using fakeroot. I had to patch the Makefile for Fedora, you may wish to
review this in the .deb

3. You may wish to review the locations of the display-dhammapada .txt
files. By default , /usr/lib and /usr/local/lib are used. I am not sure
if either are appropriate, so I moved it to /usr/share

in display-dhammapada.c

#define DPPATHNAME "/usr/local/lib/display-dhammapada/dhammapada-
english-transl.txt:/usr/lib/display-dhammapada/dhammapada-english-
transl.txt:/usr/share/display-dhammapada/dhammapada-english-transl.txt"

#define DPPATHNAME_ALT "/usr/local/lib/display-dhammapada/dhammapada-
alternate.txt:/usr/lib/display-dhammapada/dhammapada-
alternate.txt:/usr/share/display-dhammapada/dhammapada-alternate.txt"

#define DPPATHNAME_PL "/usr/local/lib/display-dhammapada/dhammapada-
polish-transl.txt:/usr/lib/display-dhammapada/dhammapada-polish-
transl.txt:/usr/share/display-dhammapada/dhammapada-polish-transl.txt"


4. I think the file examples/xsession should start with a shee-bang

#! /bin/sh

I will report this on Debian as well, not sure how active upstream (from
Debian) is ...

** Affects: display-dhammapada (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1014195

Title:
  documentation needs updating

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/display-dhammapada/+bug/1014195/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to