Comments about the patch: * Evaluating the files in .d/ in reverse order is counterintuitive and error prone (on the side of the admin) * Since there is no patch system, the changelog should point out the modified files and functions (common practice: " * foo/foo.c, frobnicate(): blabla"), and explain the behavioural change of the patch in more detail. Same for the TeX transition; "Limit" is a bit misleading, what about "Build with texlive"; so -extra has never actually been necessary? * The changelog should close the bug (LP: #xxx) and refer to the spec
Since this patch alters the behaviour of a sensitive part of the system, it should be discussed with upstream and get their blessing (or, even better, adoption). However, see my comments in the spec, I'm not convinced that the patch in this form is sufficient for the spec. -- patch to add directory inclusion for pam config file https://bugs.launchpad.net/bugs/116846 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
