On Tue, Feb 14, 2012 at 6:09 PM, Evan Dandrea <evan.dand...@canonical.com> wrote: > On Fri, Feb 10, 2012 at 4:19 PM, Jamie Strandboge <ja...@ubuntu.com> wrote: >> * get_crash_db_url(): needs to verify the url. Granted, it should be >> tightly controlled via the initscript or the root user, but still. > > Verified how? I could ensure there's an http:// on the front and a NUL > terminator on the end, but beyond that I'm unsure what else we could > do.
Done (r167). >> I wrote some test cases to demonstrate the problem and will attach the >> tarball to this bug. Basically I pulled parse_report() out into its own >> file, compiled it and then ran it over the test data. Please incorporate >> this test data into your testsuite and use a similar methodology as the >> test.sh script. I also advise in your test scripts to verify that the >> output of parse_report() is what you want it to be, even in the face of >> malformed data. Finally, my invalid test cases are in no way >> comprehensive-- please add more! :) > > I'll work on this now, with the hope of getting it done by the end of > the day tomorrow. Done (r168-179). I believe with these changes I've addressed your remaining concerns, but do let me know if there's anything else that's caught your eye or anything you feel I've missed. Jamie, from your perspective, is the package ready to go into main? Thanks again for all of your hard work reviewing this and for the sample data. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/913694 Title: [MIR] whoopsie-daisy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/whoopsie-daisy/+bug/913694/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
