Launchpad has imported 14 comments from the remote bug at
http://bugs.gentoo.org/show_bug.cgi?id=364009.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2011-04-18T10:46:29+00:00 Fsvm88 wrote:

I tried to compile media-video/avidemux-2.5.4-r2, but the compile phase
always fails. I have been able to patch the problem successfully. GCC
4.6 is stricter than previous versions and avidemux code triggers some
spots where some particular code semantics is not allowed by the
standard.


Reproducible: Always

Steps to Reproduce:
1. emerge -1 gcc:4.6
2. use it as default compiler
3. emerge -1 avidemux
Actual Results:  
Avidemux fails to compile.

Expected Results:  
Avidemux should compile fine.

I'm on ~amd64 but I guess the compile errors should show up on any architecture 
when using GCC 4.6. The errors arise because GCC 4.6 is stricter than previous 
versions about code semantics. I tried with and without graphite flags (whole 
world was recompiled), and all of the available versions in portage. I have 
tried also the SVN ebuild from multimedia overlay but it still fails in the 
same spots.
The three attached patches resolve the problems and allow avidemux to compile 
fine. I've tested the avidemux GUI interface which is the affected part and it 
works ok.
It should not introduce errors with previous GCC versions since the patch is 
cosmetic only (I've been unable to test with GCC<4.6).
I guess this should also be filed upstream.
Thanks.

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/0

------------------------------------------------------------------------
On 2011-04-18T10:47:02+00:00 Fsvm88 wrote:

Created attachment 270363
Patch for QT4 "Open file" GUI

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/1

------------------------------------------------------------------------
On 2011-04-18T10:47:35+00:00 Fsvm88 wrote:

Created attachment 270365
Patch for x264 "Preset" GUI

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/2

------------------------------------------------------------------------
On 2011-04-18T10:48:03+00:00 Fsvm88 wrote:

Created attachment 270367
Patch for xvid "Preset" GUI

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/3

------------------------------------------------------------------------
On 2011-04-18T11:58:46+00:00 Serkan Kaba wrote:

Please post the patch upstream.

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/4

------------------------------------------------------------------------
On 2011-04-18T12:43:50+00:00 Fsvm88 wrote:

(In reply to comment #4)
> Please post the patch upstream.

Done.
According to the thread on the forums the patches for qt4 and x264 interfaces 
have already been coded upstream.
I linked this bug and asked to pull the xvid one if it is still missing.

http://avidemux.org/admForum/viewtopic.php?pid=50437#p50437

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/5

------------------------------------------------------------------------
On 2011-04-18T15:10:28+00:00 Serkan Kaba wrote:

(In reply to comment #5)
> (In reply to comment #4)
> > Please post the patch upstream.
> 
> Done.
> According to the thread on the forums the patches for qt4 and x264 interfaces
> have already been coded upstream.
> I linked this bug and asked to pull the xvid one if it is still missing.
> 
> http://avidemux.org/admForum/viewtopic.php?pid=50437#p50437

Thanks, I modified the URL field accordingly. Let's wait until upstream
acknowledges/commits your patch.

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/6

------------------------------------------------------------------------
On 2011-04-20T21:03:17+00:00 Billydv1 wrote:

Created attachment 270721
avidemux-2.5.4-r2.ebuild

Attached a working ebuild. Download all 3 patches and place in files
directory. Indeed patches work.

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/8

------------------------------------------------------------------------
On 2011-04-22T01:26:06+00:00 Galtgendo wrote:

*** Bug 364029 has been marked as a duplicate of this bug. ***

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/9

------------------------------------------------------------------------
On 2011-04-22T09:02:34+00:00 Hwoarang wrote:

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Please post the patch upstream.
> > 
> > Done.
> > According to the thread on the forums the patches for qt4 and x264 
> > interfaces
> > have already been coded upstream.
> > I linked this bug and asked to pull the xvid one if it is still missing.
> > 
> > http://avidemux.org/admForum/viewtopic.php?pid=50437#p50437
> 
> Thanks, I modified the URL field accordingly. Let's wait until upstream
> acknowledges/commits your patch.

The upstream url seems broken or there is something wrong with their
website. I will wait a little bit longer for their reply before I commit
your patches

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/10

------------------------------------------------------------------------
On 2011-04-28T15:27:38+00:00 Hwoarang wrote:

Their forum changed URL ( http://avidemux.org/smf/index.php ). Can you
post the new URL of your thread

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/11

------------------------------------------------------------------------
On 2011-04-29T09:41:02+00:00 Fsvm88 wrote:

The thread was not mine, it was opened by a Fedora developer.
Avidemux.org have migrated their forums and it seems that the thread were this 
issue was being discussed has been lost in the transition.
However, by cloning the svn, I can confirm that the qt4_ui and x264_ui patches 
have been applied, while the xvid_ui one has not.
I re-opened the thread on the forums under the same name and asked to pull the 
Xvid patch. The URL field has been modified accordingly.

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/12

------------------------------------------------------------------------
On 2011-04-29T09:44:17+00:00 Fsvm88 wrote:

s/thread were this/thread where this/

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/13

------------------------------------------------------------------------
On 2011-04-29T14:11:15+00:00 Hwoarang wrote:

  29 Apr 2011; Markos Chandras <hwoar...@gentoo.org> avidemux-2.5.4-r2.ebuild,
  +files/avidemux-2.5.4-openfileqt.patch,
  +files/avidemux-2.5.4-x264-build115.patch, +files/avidemux-2.5.4-x264.patch,
  +files/avidemux-2.5.4-xvid.patch:
  Add gcc-4.6 patches thanks to Fabio Scaccabarozzi <fsv...@gmail.com>. Add
  patch for latest x264 thanks to zimous <zim...@matfyz.cz>. Bugs #364009 and
  #365153

Fixed. Thanks :)

Reply at: https://bugs.launchpad.net/avidemux/+bug/766017/comments/14


** Changed in: gentoo
       Status: Unknown => Fix Released

** Changed in: gentoo
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/766017

Title:
  avidemux version 1:2.5.4-0ubuntu6 failed to build on i386

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to