Please see the man page for xscreensaver-getimage for an explication of
the chooseRandomImages option. Setting it to false does not mean images
should be selected sequentially. So the "bug report" here is invalid.

However, a feature to have a sequential slide show sounds like a good idea. I 
would encourage you to make an "upstreamable" patch. I don't see why Ubuntu 
should carry such a delta in form of a undocumented "hack". There is also a 
couple of issues in your patch (which seems to have been released in Natty 
without any review) which I have tried to address in the attached patch:
1) there is no checking for index overflow once the image list has run out
2) the hard-coded index counter file name is not portable
3) the counter is incremented, then decremented in a conditional clause 
(confusing)

I have omitted the check for chooseRandomImages in the configuration
file, and just rely on the existence of an index file. It might make
sense to check for a "chooseSequentialImages" option instead, which also
needs to be honoured in other code. But the upstream developer might
have other suggestions for how to implement this.

BTW, is this part of a bigger plan for something in Ubuntu, or just a
private "itch"?

** Patch added: "suggestion for better patch"
   
https://bugs.launchpad.net/ubuntu/+source/xscreensaver/+bug/671514/+attachment/1785907/+files/xscreensaver-getimage-file.diff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/671514

Title:
  xscreensaver-getimage and xscreensaver-getimage-file don't respect 
"chooseRandomImages: False" in .xscreensaver

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to