> But this can only happen when CrashCounter is 0, and in that case the
behavior is also correct, IIRC.

Yes, I think so. Case 1 is when the old report is not touched before the
next one comes in:

$ ls /var/crash; if /usr/share/apport/apport-checkreports; then echo unseen; 
else echo nothing; fi
nothing
$ bash -c 'kill -SEGV $$'
Segmentation fault (Speicherabzug geschrieben)
$ ls /var/crash; if /usr/share/apport/apport-checkreports; then echo unseen; 
else echo nothing; fi
_bin_bash.1000.crash
bash
unseen
$ bash -c 'kill -SEGV $$'
Segmentation fault (Speicherabzug geschrieben)
$ ls /var/crash; if /usr/share/apport/apport-checkreports; then echo unseen; 
else echo nothing; fi
_bin_bash.1000.crash
bash
unseen
$ tail -n 1 /var/log/apport.log
apport (pid 5256) Fri Apr 16 12:11:50 2010: apport: report 
/var/crash/_bin_bash.1000.crash already exists and unseen, doing nothing to 
avoid disk usage DoS
$ grep CrashCounter /var/crash/_bin_bash.1000.crash 
$

(Since it doesn't even open unseen reports to check for CrashCounter).

Case 2 if the report is touched:

$ ls /var/crash; if /usr/share/apport/apport-checkreports; then echo unseen; 
else echo nothing; fi
nothing
$ bash -c 'kill -SEGV $$'
Segmentation fault (Speicherabzug geschrieben)
$ ls /var/crash; if /usr/share/apport/apport-checkreports; then echo unseen; 
else echo nothing; fi
_bin_bash.1000.crash
bash
unseen
$ head /var/crash/_bin_bash.1000.crash >/dev/null   # <--- THIS MARKS IT AS 
"SEEN"
$ bash -c 'kill -SEGV $$'
Segmentation fault (Speicherabzug geschrieben)
$ ls /var/crash; if /usr/share/apport/apport-checkreports; then echo unseen; 
else echo nothing; fi
_bin_bash.1000.crash
bash
unseen
$ tail -n 1 /var/log/apport.logapport (pid 5394) Fri Apr 16 12:14:12 2010: 
wrote report /var/crash/_bin_bash.1000.crash
$ grep CrashCounter /var/crash/_bin_bash.1000.crash 
CrashCounter: 1

So I believe this is correct.

Thanks!

** Changed in: apport (Ubuntu)
       Status: Incomplete => Invalid

-- 
Repeat check marks crash reports as "seen"
https://bugs.launchpad.net/bugs/558346
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to