I am CCing everyone who has made Ubuntu packages of Gutenprint, as most of the numerous changes were already there when I started packaging Gutenprint for Ubuntu.
See the remarks below. Roger Leigh wrote: > > Thanks for letting me know that there is a new version in Ubuntu. > However, I'm not sure why I have been notified or what I would need to > do about it, not being an Ubuntu developer. > You got automatically informed because you were subscribed to the Ubuntu bug #49895 (https://launchpad.net/ubuntu/+source/gutenprint/+bug/49895). Then you get e-mail whenever someone posts a comment or changes someting on this bug report. Unsubscribe from the bug report if you do not want to get e-mail about it any more. > As the Debian packager of gutenprint, I am a little worried about some > of the changes: > > configure.ac: > > +- AC_DEFINE_UNQUOTED(CUPS_MODELDIR, "${cups_conf_datadir}/model/") > ++ AC_DEFINE_UNQUOTED(CUPS_MODELDIR, "/usr/share/ppd/") > + else > +- AC_DEFINE_UNQUOTED(CUPS_MODELDIR, > "${cups_conf_datadir}/model/${PACKAGE}/${GUTENPRINT_RELEASE_VERSION}/") > ++ AC_DEFINE_UNQUOTED(CUPS_MODELDIR, > "/usr/share/ppd/${PACKAGE}/${GUTENPRINT_RELEASE_VERSION}/") > > man/cups-genppdconfig.8.in: > > [EMAIL PROTECTED]@/model/gutenprint\fP. > ++\fP/usr/share/ppd/gutenprint\fP. > > man/cups-genppdupdate.8.in: > > +-CUPS, using the PPD files under [EMAIL PROTECTED]@/model/gutenprint\fP as > ++CUPS, using the PPD files under \fI/usr/share/ppd/gutenprint\fP as > > cups/Makefile.am: > > +-cups_modeldir = $(pkgdatadir)/model/ > ++cups_modeldir = /usr/share/ppd/ > > +-cups_modeldir = $(pkgdatadir)/model/gutenprint/@[EMAIL > PROTECTED]@GUTENPRINT_MINOR_VERSION@/ > ++cups_modeldir = /usr/share/ppd/gutenprint/@[EMAIL > PROTECTED]@GUTENPRINT_MINOR_VERSION@/ > > src/cups/cups-genppdconfig.in: > > +-my $chosen_location = "@cups_conf_datadir@/model/gutenprint/$version"; > ++my $chosen_location = "/usr/share/ppd/gutenprint/$version"; > > src/cups/cups-genppdupdate.in: > > +-my $ppd_root_dir = "@cups_conf_datadir@/model"; > ++my $ppd_root_dir = "/usr/share/ppd"; > > Rather than hacking "/usr/share/ppd" in all over the place, simply > changing it in one place (configure.ac) by redefining and AC_SUBSTing > CUPS_MODELDIR would be sufficient, then you could use the variable > throughout and it won't break --prefix, which is rather important. It > would also be suitable for submission back upstream, which is also an > important consideration when making changes. > I was already annoyed about that there were so may changes in the .diff.gz outside the debian/ directory. I usually try to have only files in the debian/ in the .diff.gz. Everything has to work by patches and scripts in the debian/ directory. I tried to reach this goal also with Gutenprint when I did the first merge with Debian, but running the autotools did not work for me under Ubuntu. So I asked the others at Ubuntu what to do and so it stayed this way. > * Many of the changelog entries could use more descriptive > explanations. > > * "Updated to current CVS snapshot of Gutenprint" > > - Which branch? What date? Which files? > Sorry for not mentioning the branch here, date is in the version number. > - Pulling from the mainline in a *stable* release is not encouraged. > There are ABI and stability issues to consider, and your upstream > (Debian) will only apply selected patches from the 5.0 branch > after careful review. Sorry, I already returned to the stable branch (version 5.0.1). The CVS snapshot was more for many people testing Canon drivers and the new efforts on borderless printing. > This is the current diff in the upstream > tarball between Ubuntu and Debian (gutenprint-5.0.0 vs > gutenprint-5.0.0+cvs20070127): > > AUTHORS | 2 > ChangeLog | 1101 + > Makefile.am | 3 > Makefile.in | 55 [... Skipping a nearly complete list of the files in the source tarball ...] > test/pixma_parse.h | 255 > 296 files changed, 72329 insertions(+), 86661 deletions(-) > So then the stable and the unstable branch got compared. Now, with the 5.0.1 RC1 the situation should be much better. > Frankly, this is rather excessive set of changes to apply. I simply > can't consider merging such changes in Debian, which will generally > only package the stable release for general use > (stable/testing/unstable), or possibly a late beta or release > candidate if we are a long way from release, which is not the case at > the moment. This will make future merging of changes between Debian > and Ubuntu rather more work than it should need to be. > > Lastly, pushing changes back upstream to Debian should make your life > easier, if you were to send me patches of your changes. Till -- Print to CD has wrong size https://launchpad.net/bugs/49895 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
