From: Loïc Minier <l...@dooz.org>
   Date: Fri, 15 Jan 2010 13:48:12 -0000
   
   I can't reproduce this with the sequence of commands you posted and the
   code looks correct to me.
   
   I think there are two cases in which the script is broken: if it's
   called with sh -e (or from a set -e shell) or if it's interrupted (e.g.
   ^C).

The /bin/bzdiff script looks broken here.  I didn't call the script
with sh -e or interrupt the script.  Maybe the script has been fixed
or rewritten in a latter version.

The bzdiff script creates a tmp file when it is called:

  tmp=`mktemp ${TMPDIR:-/tmp}/bzdiff.XXXXXXXXXX`

The tmp file is deleted using /bin/rm in one and only one case where
comparing one .bz2 file to another .bz2 file.

I can fix the problem here by moving the '/bin/rm -f $tmp;;' line to 
just before the exit line.

I've attached the /bin/bzdiff source and bzdiff.diff for my patched
version that fixes the problem for me on Ubuntu 8.04.  My patch deletes
the tmp file in all cases.  A possibly better fix would be to create
the tmp file only in the one case where it is needed.

Thanks.
-jeff





   Could you please give more details about the environment?  Does this
   happen with a new user?
   
   ** Changed in: bzip2 (Ubuntu)
          Status: New => Incomplete
   
   -- 
   bzdiff leaves files in /tmp
   https://bugs.launchpad.net/bugs/456475
   You received this bug notification because you are a direct subscriber
   of the bug.
   
   Status in “bzip2” package in Ubuntu: Incomplete
   
   Bug description:
   Binary package hint: bzip2
   
   % pushd /tmp
   /tmp ~
   % echo "fubar" >> fubar
   % echo "fubar" >> foobar
   % bzip2 foobar
   % ls -la /tmp/bzdif*
   ls: cannot access /tmp/bzdif*: No such file or directory
   % bzdiff foobar.bz2 fubar
   % ls -la /tmp/bzdif*
   -rw------- 1 jeff dstaff 0 2009-10-20 12:49 /tmp/bzdiff.LVsUd23693
   % rm fubar foobar.bz2  /tmp/bzdiff.*
   
   ProblemType: Bug
   Architecture: i386
   Date: Tue Oct 20 12:52:45 2009
   Dependencies:
    libgcc1 1:4.2.4-1ubuntu4
    libbz2-1.0 1.0.4-2ubuntu4
    gcc-4.2-base 4.2.4-1ubuntu4
    libc6 2.7-10ubuntu5
   DistroRelease: Ubuntu 8.04
   Package: bzip2 1.0.4-2ubuntu4
   PackageArchitecture: i386
   ProcEnviron:
    
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/home/username/bin
    LANG=en_US.iso-8859-1
    SHELL=/bin/bash
   SourcePackage: bzip2
   Uname: Linux 2.6.24-24-386 i686
   
   To unsubscribe from this bug, go to:
   https://bugs.launchpad.net/ubuntu/+source/bzip2/+bug/456475/+subscribe


** Attachment added: "bzdiff"
   http://launchpadlibrarian.net/37923615/bzdiff

** Attachment added: "bzdiff.diff"
   http://launchpadlibrarian.net/37923616/bzdiff.diff

-- 
bzdiff leaves files in /tmp
https://bugs.launchpad.net/bugs/456475
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to