I've taken a look at this. The icon name in gnome-volume-control-
settings is set here in gnome-volume-control/src/gvc-mixer-control.c:

static void
set_icon_name_from_proplist (GvcMixerStream *stream,
                             pa_proplist    *l,
                             const char     *default_icon_name)
{
        const char *t;

        if ((t = pa_proplist_gets (l, PA_PROP_MEDIA_ICON_NAME))) {
                goto finish;
        }

        if ((t = pa_proplist_gets (l, PA_PROP_WINDOW_ICON_NAME))) {
                goto finish;
        }

        if ((t = pa_proplist_gets (l, PA_PROP_APPLICATION_ICON_NAME))) {
                goto finish;
        }

        if ((t = pa_proplist_gets (l, PA_PROP_MEDIA_ROLE))) {

                if (strcmp (t, "video") == 0 ||
                    strcmp (t, "phone") == 0) {
                        goto finish;
                }

                if (strcmp (t, "music") == 0) {
                        t = "audio";
                        goto finish;
                }

                if (strcmp (t, "game") == 0) {
                        t = "applications-games";
                        goto finish;
                }

                if (strcmp (t, "event") == 0) {
                        t = "dialog-information";
                        goto finish;
                }
        }

        t = default_icon_name;

 finish:
        gvc_mixer_stream_set_icon_name (stream, t);
}

I tried reducing the priority of PA_PROP_MEDIA_ICON_NAME below
PA_PROP_WINDOW_ICON_NAME and PA_PROP_APPLICATION_ICON_NAME, thinking
that was where the current icon name for the stream was coming from, but
that didn't work.

I then built it with some g_debug's in to try and work out what was
going on, and it seems that PA_PROP_MEDIA_ICON_NAME,
PA_PROP_WINDOW_ICON_NAME and PA_PROP_APPLICATION_ICON_NAME are always
empty for every stream, and the icon always comes from
PA_PROP_MEDIA_ROLE. According to the Pusleaudio documentaion,
PA_PROP_MEDIA_ROLE will only be one of the following values: "video",
"music", "game", "event", "phone", "animation", "production", "a11y".

So, I think that as a temporary solution the icon theme should be
modified to contain these icons. Suitable icons likely already exist in
the theme. Other than that, I think this is more likely a bug (or
limitation) of Pulseaudio.

What do you think Sebastien?

-- 
gnome-volume-control-settings: no application icon
https://bugs.launchpad.net/bugs/347005
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to