Wouldn't it make the code more readable (less fragmented) if we stopped doing the "early" return when != ACTIVATED and put the different code for ACTIVATED and DEACTIVATED to the bottom?
** Changed in: network-manager-applet (Ubuntu) Status: New => Incomplete ** Tags added: dxteam -- Connecting/disconnecting notification changes https://bugs.launchpad.net/bugs/328572 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs