Alberto Milone [2008-09-19 20:30 -0000]:
> Yes, the contents of jockeyKde (i.e. 2 .py files) are generated automatically
> at build time. They are real modules which are imported by jockey-kde.
>
> Moving jockeyKde into kde/ (in the source code) wouldn't be a problem.
Great.
> > * generateui is a two-line script which is not called by anything
> > else. Can it just go?
>
> generateui can be useful when a developer changes the ui files with
> QtDesigner
> and then wants to see the result in the .py file without having to build the
> package.
>
> If you want, I can get rid of it and reuse convertpykde.py by simply adding
> an
> if __name__ == "__main__": convertUi()
Right, and make that executable. One file less to worry about. :-)
However, I don't think it's too bad to just call setup.py build.
> > * {convert,make}pykde.py do not look jockey specific. Shouldn't they
> > be part of python-kde4-dev?
> >
> If you prefer, I can get rid of them by calling /usr/bin/pykdeuic4 with
> subprocess in setup.py, it wouldn't be as elegant though (I couldn't check
> exceptions in case of malformed .ui files, etc.).
Doesn't pykdeuic4 provide error handling/reporting as well? I'd rather
not keep duplicated code in jockey if we can avoid it in any way.
Build tools like those are prone to change over time and should really
be kept centralized.
Thanks!
--
KDE interface fails to start: No module named kurllabel
https://bugs.launchpad.net/bugs/271935
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
