I don't think this patch is appropriate as it stands. You have to be careful not to mount a partition from the hard disk. Remember that cdrom-detect is used on regular Ubuntu CDs too. Let's say a normal from- CD Ubuntu installation happened to encounter a partition on the hard disk that happened to look a bit like an Ubuntu CD. With your patch, it might well end up mounting it and merrily carry on with installing from it. Unfortunately, if you have any partitions on a hard disk mounted, you can't usefully perform partitioning on that hard disk, because the kernel will have the partition table locked. This would make the installer fall over in a big heap.
I'm not saying this idea is fundamentally wrong, but it needs a bit more work. What if you're installing *to* a USB stick? You'll have the same problem as above. Perhaps this needs to be controllable using a kernel command-line option rather than something that's done by default. ** Changed in: cdrom-detect (Ubuntu) Importance: Undecided => Medium -- Alternate CD cdrom-detect.postinst does not consider USB flash drive/key. https://bugs.launchpad.net/bugs/234185 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
