Review: Approve
Approve but some small comments unrelated to this PR :)
Diff comments:
> diff --git a/security-tools/fetch-debdiff b/security-tools/fetch-debdiff
> index 051f58b..11386cd 100755
> --- a/security-tools/fetch-debdiff
> +++ b/security-tools/fetch-debdiff
> @@ -53,20 +57,20 @@ if len(args):
>
> url = s.changesFileUrl()
> if not url:
> - print " No changes url found?!"
> + print(" No changes url found?!")
> continue
>
> if url not in debdiff_urls:
> changes_urls.append(url)
>
> - print " Component: %s" % s.component_name
> - print " Pocket: %s" % s.pocket
> + print(" Component: %s" % s.component_name)
Not related to this PR but this part is broken, it should be inside of the for
loop
> + print(" Pocket: %s" % s.pocket)
> for url in debdiff_urls:
> - print " Debdiff:",
Also not related to the PR, but lpl_common.download doesn't return anything. It
would make more sense to print the URL here
> - lpl_common.download(opener, url)
> + print(" Debdiff:",
> + lpl_common.download(opener, url))
>
> for url in changes_urls:
> - print " Changes:",
> - lpl_common.download(opener, url)
> + print(" Changes:",
> + lpl_common.download(opener, url))
>
> - print ""
> + print("")
--
https://code.launchpad.net/~sespiros/ubuntu-qa-tools/+git/ubuntu-qa-tools-1/+merge/442767
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
_______________________________________________
Mailing list: https://launchpad.net/~ubuntu-bugcontrol
Post to : ubuntu-bugcontrol@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-bugcontrol
More help : https://help.launchpad.net/ListHelp
