Hi Fabio,
On 8/12/26 11:48 PM, Fabio Estevam wrote:
Hi Quentin,
On Wed, Aug 12, 2026 at 5:05 AM Quentin Schulz <[email protected]> wrote:
It should be !CONFIG_IS_ENABLED(DM_I2C) as CONFIG_IS_ENABLED is going to
add the appropriate prefix based on the current stage being built (so
definitely no SPL/TPL/VPL to be added manually) and CONFIG_SPL_I2C is
not enough to build the dm_i2c_probe implementation, we need
CONFIG_SPL_DM_I2C (well, and CONFIG_SPL_I2C because otherwise the
drivers/i2c directory isn't traversed and because SPL_DM_I2C is missing
a dependency on it).
I tested !CONFIG_IS_ENABLED(DM_I2C) alone, but the mezzanine SPL still
fails to link because SPL_DM_I2C is enabled while SPL_I2C is not.
Yes, because SPL_DM_I2C (and TPL_DM_I2C) do not depend on
SPL_I2C/TPL_I2C but should. Something else to fix :)
Checking both works:
if (!(CONFIG_IS_ENABLED(I2C) && CONFIG_IS_ENABLED(DM_I2C)))
return false;
I tested the mezzanine build successfully with this change.
I'll use this in v5 unless you see an issue.
Works for me!
Cheers,
Quentin
