Hi Johan, Please squash patches 5, 6, 7 and 8 with this one.
On 8/6/26 1:12 PM, Johan Jonker wrote:
Remove README.rockchip for info that's already in rockchip.rst or no longer applicable. Signed-off-by: Johan Jonker <[email protected]> Reviewed-by: Simon Glass <[email protected]> ---
[...]
- -The rockchip bootrom can load and boot an initial spl, then continue to -load a second-stage bootloader (ie. U-Boot) as soon as the control is returned -to the bootrom. Both the RK3288 and the RK3036 use this special boot sequence. -The configuration option enabling this is: - - CONFIG_SPL_ROCKCHIP_BACK_TO_BROM=y -
I think this paragraph is still somewhat useful info, can you please move it somewhere in doc/board/rockchip/rockchip.rst?
[...]
-Note: rk3036 SDMMC and debug uart use the same iomux, so if you boot from SD, the - debug uart must be disabled -
This note is useful information, can you please move it to doc/board/rockchip/rockchip.rst next to RK3036-specific sections?
[...]
-The bootrom of rk3188 expects to find a small 1kb loader which returns -control to the bootrom, after which it will load the real loader, which -can then be up to 29kb in size and does the regular ddr init. This is -handled by a single image (built as the SPL stage) that tests whether -it is handled for the first or second time via code executed from the -boot0-hook. -
This info is in helptext of xPL_ROCKCHIP_EARLYRETURN_TO_BROM so I guess it's fine to remove it (also, it applies to rk3066 as well). Just wanted to mention it since it is a very important piece of information I read for the first time when reading doc/README.rockchip when reviewing one of the earlier versions of this series.
Looks good to me otherwise, thanks for cleaning this up after so many years being left untouched!
Cheers, Quentin
