On Mon, Nov 19, 2012 at 12:30:02PM -0700, Stephen Warren wrote: > On 11/09/2012 02:22 AM, Piotr Wilczek wrote: > > From: Lukasz Majewski <l.majew...@samsung.com> > > > > This move is necessary to export gpt header and GPT partition entries to be > > used with other commands or subsystems (like DFU in the future) > > Additionally the part_efi.h file has been cleaned-up to supress checkpatch's > > warnings. > > > {disk => include}/part_efi.h | 0 > > I can understand the "gpt" command perhaps needing access to the > GPT-specific types, but I would hope that anything DFU-related would be > using types from include/part.h; I don't imagine that DFU would need to > know anything about GPT at all?
Indeed. DFU must not get coupled to GPT (or for that matter, partitions) in the general code. There should be "DFU write to a GPT-using backing store" code, if that's needed. Not all eMMC would be GPT-using, for example. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot