Hi Lucas, On Fri, Oct 26, 2012 at 3:13 AM, Marek Vasut <ma...@denx.de> wrote: > Dear Lucas Stach, > >> Hi Marek, >> >> Am Freitag, den 26.10.2012, 09:09 +0200 schrieb Marek Vasut: >> > Dear Lucas Stach, >> > >> > > Move the Tegra EHCI implementation to the correct directory in the >> > > tree. This code is specific to the Tegra EHCI controller, not to the >> > > Tegra SoC in general. >> > > >> > > This is not just a move of the code, but also some small changes >> > > squashed >> > >> > Unsquash them please, it's really hard to review. Also, use git >> > format-patch -M -C to generate the patchset and to detect renames. >> >> I've generated the patch with format-patch -B -M -C, so what you see is >> basically the diff of the original file with the new implementation. So >> the diff shows all the small changes I blather about. >> >> The changes are squashed in because I did them while moving the >> implementation over, and I would like to avoid doing them in single >> patches as it's notably more work and IMHO with the current diff you can >> clearly see what changed. So please let me know if you are really that >> keen to have them as separate patches, but it may take me some while to >> respin this as I'm occupied with other things right now. > [...] > > Let's do it properly please.
Sorry, but I agree. I did start reviewing it, but stopped because really we shouldn't have so many things in one patch. Regards, Simon > > Best regards, > Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
