On 10/23/2012 3:56 PM, Stefan Roese wrote:
On 10/23/2012 12:05 PM, Vikram Narayanan wrote:As dummy{1,2} are not used anywhere, mark it with __maybe_unusedSigned-off-by: Vikram Narayanan<vikram...@gmail.com> Cc: Stefan Roese<s...@denx.de> --- common/spl/spl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 0d829c0..62fd3bd 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -145,7 +145,7 @@ static void spl_ram_load_image(void) } #endif -void board_init_r(gd_t *dummy1, ulong dummy2) +void board_init_r(__maybe_unused gd_t *dummy1, __maybe_unused ulong dummy2) { u32 boot_device; debug(">>spl:board_init_r()\n");Perhaps even __always_unused instead of __maybe_unused as these variables are never used?
Yes. It is better, in the case if it is never used at all. Thanks, Vikram _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
