On Tue, Oct 16, 2012 at 07:28:24PM -0500, Kim Phillips wrote: > traps.c:*:1: warning: symbol 'print_backtrace' was not declared. Should it be > static? > traps.c:66:6: warning: symbol 'show_regs' was not declared. Should it be > static? > traps.c:93:1: warning: symbol '_exception' was not declared. Should it be > static? > board.c:166:6: warning: symbol '__board_add_ram_info' was not declared. > Should it be static? > board.c:174:5: warning: symbol '__board_flash_wp_on' was not declared. Should > it be static? > board.c:187:6: warning: symbol '__cpu_secondary_init_r' was not declared. > Should it be static? > board.c:265:12: warning: symbol 'init_sequence' was not declared. Should it > be static? > board.c:348:5: warning: symbol '__fixup_cpu' was not declared. Should it be > static? > board.c:405:53: warning: Using plain integer as NULL pointer > > Signed-off-by: Kim Phillips <kim.phill...@freescale.com> > --- > arch/powerpc/cpu/74xx_7xx/traps.c | 6 +++--- > arch/powerpc/cpu/mpc512x/traps.c | 6 +++--- > arch/powerpc/cpu/mpc5xx/traps.c | 6 +++--- > arch/powerpc/cpu/mpc5xxx/traps.c | 6 +++--- > arch/powerpc/cpu/mpc8220/traps.c | 6 +++--- > arch/powerpc/cpu/mpc824x/traps.c | 6 +++--- > arch/powerpc/cpu/mpc8260/traps.c | 6 +++--- > arch/powerpc/cpu/mpc83xx/traps.c | 6 +++--- > arch/powerpc/cpu/mpc85xx/traps.c | 6 +++--- > arch/powerpc/cpu/mpc86xx/traps.c | 6 +++--- > arch/powerpc/cpu/mpc8xx/traps.c | 6 +++--- > arch/powerpc/cpu/ppc4xx/traps.c | 6 +++--- > arch/powerpc/lib/board.c | 12 ++++++------ > 13 files changed, 42 insertions(+), 42 deletions(-) > > diff --git a/arch/powerpc/cpu/74xx_7xx/traps.c > b/arch/powerpc/cpu/74xx_7xx/traps.c > index 7ae81eb..4f77202 100644 > --- a/arch/powerpc/cpu/74xx_7xx/traps.c > +++ b/arch/powerpc/cpu/74xx_7xx/traps.c > @@ -48,7 +48,7 @@ extern unsigned long search_exception_table(unsigned long); > * Trap & Exception support > */ > > -void > +static void > print_backtrace(unsigned long *sp)
This isn't the right form, can you fix these kind of checkpatch warnings while you're in here? A full fix of the files would be nice, but not required. And I'll just assume the rest of the series finds similar issues, thanks. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
