-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/10/12 17:05, Stephen Warren wrote:
> From: Stephen Warren <swar...@nvidia.com>
>
> Implement "ls" and "fsload" commands that act like
> {fat,ext2}{ls,load}, and transparently handle either file-system.
> This scheme could easily be extended to other filesystem types; I
> only didn't do it for zfs because I don't have any filesystems of
> that type.
>
> Signed-off-by: Stephen Warren <swar...@nvidia.com> --- There are a
> couple FIXMEs in here:
>
> 1) In fs/fs.c, code is ifdef on CONFIG_CMD_FAT or CONFIG_CMD_EXT2.
> This means that the new commands and code can only be enabled if
> the "legacy" {fat,ext2}{ls,load} are enabled. What we really want
> is CONFIG_FS_FAT and CONFIG_FS_EXT2 to enable the filesystem code,
> and then CONFIG_CMD_FAT, CONFIG_CMD_EXT2, CONFIG_CMD_FS to only
> affect the command implementations. However, that would require
> making every include/config/*.h that sets the current defines also
> set more. I suppose that's a fairly mechanical change though, so
> easy enough to implement. Does that seem like a reasonable approach
> to people?
How about a new CONFIG_CMD_GENERIC_FS for the new ls/fsload (and any
later commands like write that get added) and once most filesystems
are converted we can think about a transition plan?
> 2) In common/Makefile, I need to make this conditional upon
> CONFIG_CMD_FS or similar.
>
> Also, I wonder if the fs/* and common/* should be two separate
> patches or not?
One is fine.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQdvgNAAoJENk4IS6UOR1Wx3gP/iRvYq0khe6ZPRbUcPyTg0r8
tkNJGfglXba52GHjU6URwSrPbN9qOHzh6fD0x26jOdj1vWlMv6nvwmyo3ttvyRLe
4VF7tvTRp3Zv461vGwm8XwAXlDXVrnsWeC4veWxo+/ptFaq2FTWYTVNo2MsqHSIN
VNnxMdgtqUIU2kgx0uJst1Fl3olDaRlQmyf88SiRE2et21FQytk/LxAc50zmNr5J
UWgVgzoUP+RnZwnZK2CWL9cAuGbEyLjQvoKK8V72dMvKzZgMFpyMEdk0+onKFYe1
Byai7INodWIhWrtQj4nGC/1WQC+kCteMvF3OTjuGY/bfDPqLYx3071kocrgYWSW4
URvvdv6hn1l+evN5BQ1erwAekwfgrfcKkavJwmuVES3ZESrEyComqWEjajqeTe/6
uIpZo58oFGojJZK1HcDmaVFyj7nxAzXloupmHiKq+xfXHbv60ZUZO6InEos/ZCjZ
bpT92wyyqTeiD70glLvLRyStKzZidqeoVTkbGM0XUCA3d3RvxXdB4zfgIqDlhhCT
EfhxKVkAZAzjsEn+U1/y5RWEEdD+Zaqi2xKwA+Ken9TJ4LFsjcOiQDPVZYklD7qu
Xmte9GdxL4tSipu0hWxrkRjO7ap09wUoEk1d0jNSrwNbJALnUUkT4qfpYXcMaAhe
okjWSANQaBZxbM0ziEoT
=AnRj
-----END PGP SIGNATURE-----
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
