Hi Tom, > On Tue, Oct 09, 2012 at 01:34:35PM +0200, Stefano Babic wrote: > > On 09/10/2012 12:25, Lukasz Majewski wrote: > [snip] > > >> We use often the "weak" mechanism to avoid that a board > > >> maintainer is constrained to implement an empty function only to > > >> make happy the linker. It is better to declare the function as > > >> weak and call it with the same schema, such as > > >> board_power_init() (several board_* are weak) > > > > > > Correct me if I'm wrong, but weren't we recently trying to remove > > > functions defined as weak? > > > > I am not aware of it. I see several patches in last days adding weak > > function. Several weak function are present in the recent added SPL > > framework. > > We should use weak functions when we can provide a functioning in many > cases default but need to allow for overrides in some cases. We > shouldn't use them when everyone needs to define the function and it > has to do something. >
Ok, thanks for clarification :-). I will define and use board_power_init() as a __weak function. -- Best regards, Lukasz Majewski Samsung Poland R&D Center | Linux Platform Group _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
