-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/05/12 10:03, Stefan Roese wrote: > On 10/05/2012 05:22 PM, Tom Rini wrote: > > <snip> > >>>>> Okay, probably better to add this code now. But shouldn't >>>>> we add this code to the common SPL framework code then? >>>>> Right before calling jump_to_image_linux()? >>>> >>>> Sure, I didn't mean it should go here (it needs to be >>>> somewhere that knows the image start/end, not just the entry >>>> point). This is just the patch that prompted me to ask the >>>> question. >>> >>> I see. >>> >>> Tom, whats your input on this? Do you see any problems about >>> putting a flush_cache() into the common SPL framework code? Are >>> any of the ARM platforms currently using this framework already >>> running with d-cache enabled? >> >> On ARM, jump_to_image_linux() calls cleanup_before_linux() to >> take care of flushing, etc. So the PowerPC jump_to_image_linux >> should take care of what it needs to take care of. > > Hmmm. Why not move this cleanup_xxx stuff into the common code as > well? Is it really that platform specific? Cache flushing is a > common problem. > > So basically a "+1" for Scotts comments. But I would suggest to > address this in a follow up patch, to consolidate all this > cleanup/cache_flush stuff. Okay?
OK, so my quick check of things shows that in SPL, arm isn't ever enabling the dcache (at least CONFIG_SPL_FRAMEWORK), we just make sure that yes, really, we're good to go for Linux kernel booting. That's why we haven't had this as a general issue yet. So in sum, yes, please come up with patches to get things in a more consistent state. It should probably be re-naming cleanup_before_linux as well and calling that as in some cases we need to do a little more than i/d_disable, flush (see the v7 one). Thanks! - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQbxnlAAoJENk4IS6UOR1WzcMP+wY7gH6kE9ryBF+Aem78dz/O 5nCBzQJg6GSpab6S4qUFGutmh0GVqMhTgA5cQrlzNt7JvZNboe15bf/u91g6RNCv q2saJzYj8wQJ7DrUQtAoNA/jdI5zLTQ8jE0Zbg8kD/MszP5NipMH7SHZTfoedVfx dAqoDpmXFbsp70E8/rtnlhP+8z5kxrw9xzZwRvtjb1oAT8w707frge4Yfa/lz2Xo vd55/CzdUYwJRKgJmdSzYjGmV+nBER6IDl76LiVg4C/xVbcc8qjO8Ebja2j8Cftr cuJ7ith/RLpMNqPQ/yNwA25MK3yBL1AA+XGADjMhMv4VjzbapRkDveUOFYzORlko jdjEOfR4g0onerjHGTkysIqIchvxPOatDm0a0+kw+JronCh9aJMJOZ0xjaBdEQ9Q xQDA+U+o45+YKFTuAAOisehJ5hmgnmqV2yH4my7CR/NcJvaV1vbq0DN1O9gIRvWU x1wUKWH/MtOs/SdIDXF+nIwI7LBK96YyTERIaOwpa01YuTkc8m6frGJZYZO1yaQU sACj3e8mQmXkkXXy6eKiY/aJLnMep1ZNOf/JobzSN+R92g01yED88T38/aqZWt80 0+N2vFmLZvg4CLWWdUbVNxU7mv14b2kCc2bI5m7zuTXdXccTausaZ9r3WZgBnY3R RPYJc0MosHUmXEozty2y =3AZY -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
