On 05/10/2012 12:46, Gerlando Falauto wrote:
> env default -a -f calls env_check_apply on all existing environment
> variables with a NULL value for "newval" as a way of cleaning up.
> This causes string manipulation functions to crash on most architectures.
> So replace a NULL argument with an empty string.
>
> Reported-By: Stefano Babic <sba...@denx.de>
> Signed-off-by: Gerlando Falauto <gerlando.fala...@keymile.com>
> ---
> common/cmd_nvedit.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
> index 3474bc6..c38b475 100644
> --- a/common/cmd_nvedit.c
> +++ b/common/cmd_nvedit.c
> @@ -213,6 +213,9 @@ int env_check_apply(const char *name, const char *oldval,
> {
> int console = -1;
>
> + /* Default value for NULL to protect string-manipulating functions */
> + newval = newval ? : "";
> +
> /* Check for console redirection */
> if (strcmp(name, "stdin") == 0)
> console = stdin;
>
It fixes the issue.
Tested-by: Stefano Babic <sba...@denx.de>
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
