Hi Graeme, On Wed, Oct 3, 2012 at 1:47 PM, Graeme Russ <graeme.r...@gmail.com> wrote: > Hi Simon, > > On Oct 4, 2012 6:40 AM, "Simon Glass" <s...@chromium.org> wrote: >> >> Hi Tom, >> >> On Wed, Oct 3, 2012 at 1:04 PM, Tom Rini <tr...@ti.com> wrote: >> > -----BEGIN PGP SIGNED MESSAGE----- >> > Hash: SHA1 >> > >> > On 10/03/12 12:53, Simon Glass wrote: >> > >> >> On x86 machines gd is unfortunately a #define, so we should avoid >> >> using gd for anything. This patch changes uses of gd to bgd so that >> >> ext4fs can be used on x86. >> >> >> >> Signed-off-by: Simon Glass <s...@chromium.org> >> > >> > Is there any way to change x86 to not be using a #define for gd? >> >> I wasn't brave enough to look hard at that, although Graeme is on copy >> and will know. It is actually using inline assembly to access this >> special variable. > > Isn't 'gd' used by everyone (global data)? I fail to see how this ever > worked.
Well only x86 uses a #define for it, so other archs cause no problem. It means that we can't use 'gd' as a symbol anywhere in U-Boot. I suppose the only sensible use is a structure member, as here. Regards, Simon > > Regards, > > Graeme _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
