On Fri, Sep 21, 2012 at 12:46:54PM -0000, Stephen Warren wrote: > From: Stephen Warren <swar...@nvidia.com> > > Now that get_device_and_partition() always calls get_partition_info() > when disk.c is compiled, we must always compile the function, rather > than ifdef it away. > > The implementation must be conditional based on CONFIG_CMD_* etc., since > that's what e.g. part_dos.c uses to ifdef out get_partition_info_dos(); > CONFIG_DOS_PARTITION can be enabled even without those commands being > enabled. > > Technically, this change is required before Rob's "disk/part: introduce > get_device_and_partition" patch. However, at least when the compiler > optimizer is turned on, it isn't required before then in practice, > since get_device_and_partition() calls get_dev(), which is stubbed out > in disk.c under exactly the same conditions that get_partition_info() > is not compiled, and hence the compiler never generates code for the > call to the missing function. However, in my later patch "disk: > get_device_and_partition() "auto" partition and cleanup", the optimizer > doesn't succeed at this, and may attempt to reference the undefined > function. > > Signed-off-by: Stephen Warren <swar...@nvidia.com>
Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
