On Tue, Aug 21, 2012 at 06:00:47PM +0200, Marek Vasut wrote:

> From: Pavel Herrmann <morpheus.i...@gmail.com>
> 
> Signed-off-by: Pavel Herrmann <morpheus.i...@gmail.com>
> Signed-off-by: Marek Vasut <ma...@denx.de>

More of a commit message please.  At least point to the design docs that
are now in tree.

> +#ifndef _COMMON_DM_TREE_H_
> +#define _COMMON_DM_TREE_H_ 1

#ifndef __COMMON_DM_TREE_H
#define __COMMON_DM_TREE_H

etc, etc.  You also pass in 'i' as a variable to one of the functions at
least.  Please make sure you use real variable names in functions.

-- 
Tom
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to