Hi, Thank you for this work. If you have a time, could you update sh_i2c using set/clrbits functions? these functions is included in asm/io.h.
For example, you can change from writeb(readb(&base->iccr) & ~SH_I2C_ICCR_ICE, &base->iccr); to clrbits_8(&base->iccr, SH_I2C_ICCR_ICE); . Best regards, Nobuhiro On Wed, Sep 12, 2012 at 5:46 PM, Tetsuyuki Kobayashi <k...@kmckk.co.jp> wrote: > Some mails seems to be missing. I am sending again.. > > > Hi, Iwamatsu-san > Hello, Heiko > > Iwamatu-san, thank you for review. This is v2 patch for sh_i2c. > Now "i2c dev" and "i2c probe" also work properly on KZM-A9-GT board. > I think this modification is common for R-mobile, but I have SH73A0 document > only. Iwamatu-san, please review this. > > This patch set is based on arm/rmobile branch of u-boot-sh.git. > > Tetsuyuki Kobayashi (9): > i2c: sh_i2c.c: support iccl and icch extension > i2c: sh_i2c.c: correct BUSY bit define in ICSR > i2c: sh_i2c.c: adjust for SH73A0 > i2c: sh_i2c.c: support I2C2, I2C3 and I2C4 > i2c: sh_i2c: enable i2c_probe > i2c: sh_i2c.c: check error in i2c_read and i2c_write > i2c: sh_i2c.c: remove unused function > arm: rmobile: kzm9g: enable I2C1 > arm: rmobile: kzm9g: enable I2C2 > > board/kmc/kzm9g/kzm9g.c | 7 ++- > drivers/i2c/sh_i2c.c | 120 > +++++++++++++++++++++++++++++++++-------------- > include/configs/kzm9g.h | 8 +++- > 3 files changed, 95 insertions(+), 40 deletions(-) > > -- > 1.7.9.5 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot -- Nobuhiro Iwamatsu _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
