Hi Stefano, > >> #define MXC_GPIO_PORT_TO_NUM(port, bit) (((port - 1) << 5) + (bit > >> & > >> 0x1f)) > > > > Keeping this is also useless. GPIO_NUMBER() from the new > > <asm/imx-common/gpio.h> > > can be used instead everywhere needed. > > That is right - I drop it.
I don't know if you are aware of it, but just to let you know, I've seen the following patch that will interfere: http://patchwork.ozlabs.org/patch/165311/ http://git.denx.de/?p=u-boot/u-boot-staging.git;a=commitdiff;h=72739219a12bf02820d29a89cb2b7fdc4d0e840f You may want to merge it to your imx tree and rebase after it for your patch. > >> > >> -/* GPIO registers */ > >> -struct gpio_regs { > >> - u32 gpio_dr; > >> - u32 gpio_dir; > >> - u32 gpio_psr; > >> -}; > >> +#include <asm/imx-common/gpio.h> > >> > >> #endif /* __ASM_ARCH_MX6_GPIO_H */ > > > > Why do you keep all these old <asm/gpio.h>? The new > > <asm/imx-common/gpio.h> can > > be included instead everywhere needed. > > No. The GPIO is common for all SOCs in u-boot, not only i.MX. The > common > interface requires that a asm/gpio.h exists. See common/cmd_gpio.c. Right. Best regards, Benoît _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
