Hi Stefano, > On 13/08/2012 22:48, Benoît Thébaudeau wrote: > > This patches fixes the TODO to use same register definitions in mtd > > mxc_nand and > > nand_spl fsl nfc drivers. > > > > Signed-off-by: Benoît Thébaudeau <benoit.thebaud...@advansee.com> > > Cc: Scott Wood <scottw...@freescale.com> > > Cc: Stefano Babic <sba...@denx.de> > > --- > > Hi Benoît, > > before going deeper in the review there is a general issue. > > nand_spl was used in the past and it was the first implementation to > have a first loader able to copy u-boot into RAM when the SOC boots > from > NAND. It is replaced by the general SPL framework. All new > implementations must use the new SPL framework, What you see under > nand_spl is referred to already supported boards. > > With general SPL, we do not have two drivers for NAND, and we are > able > to boot from other devices, too. So it makes no sense to try to > uniform > the driver under nand_spl with the main driver, we want to use only > the > main driver.
Then, I don't know what to do with these patches. Note that this is not a new implementation, but only an enhancement of the existing one. But I understand your point. I don't see any i.MX board using the general SPL for NAND. So we can't say that it's usable with the current mtd mxc_nand driver in its current state. Moreover, with the general SPL, I'd be very concerned as to the code size of mxc_nand (the target size of the whole SPL code is only 2 kiB for current i.MX users of nand_spl). IMHO, we could improve and fix the nand_spl code while it's still there and used. This does not prevent from moving to the general SPL once ready for mxc_nand. These are two different topics. Best regards, Benoît _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
