Hi Stefan, On 13.08.2012 15:37, Stefan Roese wrote: > Hi Andreas, > > On 08/13/2012 03:11 PM, Andreas Bießmann wrote: >>> +LIB := $(obj)libbootcount.o >>> + >>> +COBJS-y += bootcount.o >>> +COBJS-$(CONFIG_AT91SAM9XE) += bootcount_at91.o >> >> I tend to NAK this. Before it was available to all at91 processors (keep >> in mind nearly all at91 have this gpbr register). Now it is only >> available to AT91SAM9XE processor series which is the only user for >> bootcount in mainline. > > Then we should choose a different CONFIG_ option here. One that selects > all AT91 boards potentially supporting this feature. You are the expert > here, please make a suggestion.
Unfortunately there is no such config option yet. We could add all the SoC explicitly like this: ---8<--- | +COBJS-$(CONFIG_AT91SAM9260) += bootcount_at91.o | +COBJS-$(CONFIG_AT91SAM9261) += bootcount_at91.o | +COBJS-$(CONFIG_AT91SAM9263) += bootcount_at91.o | +COBJS-$(CONFIG_AT91SAM9G10) += bootcount_at91.o | +COBJS-$(CONFIG_AT91SAM9G20) += bootcount_at91.o | +COBJS-$(CONFIG_AT91SAM9M10G45) += bootcount_at91.o | +COBJS-$(CONFIG_AT91SAM9RL) += bootcount_at91.o | COBJS-$(CONFIG_AT91SAM9XE) += bootcount_at91.o | +COBJS-$(CONFIG_AT91SAM9G20) += bootcount_at91.o --->8--- Maybe there is some make foo to get this easier? >> I fear we may break some not mainline boards >> here. > > Maybe. But we usually don't care about out-of-tree ports. That is true, we could just wait for patches adding this feature to other at91 SoC. >> I would prefer something that includes all different at91 SoC by >> default (except rm9200). >> >> I have no solution yet but send this to prevent a v4. Will send a >> proposal for at91 later this day. > > Okay. But I would really like to see this patch go in soon. I still have > a new board support patch waiting here for quite a long time depending > on this bootcount stuff. I'm with you, do you have a suggestion how to do the make foo nice? Best regards Andreas Bießmann _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
