On 08/10/2012 04:12 PM, Benoît Thébaudeau wrote: > On Sat, Aug 11, 2012 at 12:44:34 AM +0200, Tom Rini wrote: >> On Fri, Aug 10, 2012 at 11:59:09PM +0200, Benoît Thébaudeau wrote: >> >>> save_boot_params() is called by start.S, so move its default >>> implementation to >>> this file too. This is also useful for boards willing to use >>> nand_spl since >>> cpu.c is not built in this case. >>> >>> Signed-off-by: Benoît Thébaudeau <benoit.thebaud...@advansee.com> >>> Cc: Albert Aribaud <albert.u.b...@aribaud.net> >> >> We should pick up http://patchwork.ozlabs.org/patch/169561/ instead >> as >> yours is missing START/ENDPROC > > Yes. > >> and doesn't just declare the initial >> implementation weak. > > What do you mean? It does: > +.weak save_boot_params
Yes, but you add save_boot_params_default and alias it. That's extra work we don't need :) > One version or the other, I don't care as long as one of them is applied. Why > has Tetsuyuki's patch still not been applied? You've ack'ed it on 7/9. Bad timing around the v2012.07 release. If Albert doesn't pick it up next time he goes around I'll add it to a staging tree and send a request. -- Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
